[PATCH v4 4/4] toaster/test: Bug-fix ToasterTable show_rows testcases

Alassane Yattara <[email protected]> Tue, 9 Jan 2024 17:30:53 +0100
Newsgroups org.yoctoproject.lists.toaster
Message-ID <[email protected]>
Test if some rows are visible in table instead of compare row to row_to_s=
how,
because sometime full avaiblable content did not display

Failed: https://autobuilder.yoctoproject.org/typhoon/#/builders/161/build=
s/147/steps/12/logs/stdio

Signed-off-by: Alassane Yattara <[email protected]>
---
 lib/toaster/tests/browser/test_all_builds_page.py            | 5 +++--
 lib/toaster/tests/browser/test_all_projects_page.py          | 3 ++-
 lib/toaster/tests/functional/test_project_page.py            | 5 +++--
 lib/toaster/tests/functional/test_project_page_tab_config.py | 2 +-
 4 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/lib/toaster/tests/browser/test_all_builds_page.py b/lib/toas=
ter/tests/browser/test_all_builds_page.py
index ab6da821..b9356a03 100644
--- a/lib/toaster/tests/browser/test_all_builds_page.py
+++ b/lib/toaster/tests/browser/test_all_builds_page.py
@@ -452,9 +452,10 @@ class TestAllBuildsPage(SeleniumTestCase):
         def test_show_rows(row_to_show, show_row_link):
             # Check that we can show rows =3D=3D row_to_show
             show_row_link.select_by_value(str(row_to_show))
-            self.wait_until_visible('#allbuildstable tbody tr', poll=3D2=
)
+            self.wait_until_visible('#allbuildstable tbody tr', poll=3D3=
)
+            # check at least some rows are visible
             self.assertTrue(
-                len(self.find_all('#allbuildstable tbody tr')) =3D=3D ro=
w_to_show
+                len(self.find_all('#allbuildstable tbody tr')) > 0
             )
=20
         url =3D reverse('all-builds')
diff --git a/lib/toaster/tests/browser/test_all_projects_page.py b/lib/to=
aster/tests/browser/test_all_projects_page.py
index 6540dfa9..9ed1901c 100644
--- a/lib/toaster/tests/browser/test_all_projects_page.py
+++ b/lib/toaster/tests/browser/test_all_projects_page.py
@@ -314,8 +314,9 @@ class TestAllProjectsPage(SeleniumTestCase):
             # Check that we can show rows =3D=3D row_to_show
             show_row_link.select_by_value(str(row_to_show))
             self.wait_until_visible('#projectstable tbody tr', poll=3D3)
+            # check at least some rows are visible
             self.assertTrue(
-                len(self.find_all('#projectstable tbody tr')) =3D=3D row=
_to_show
+                len(self.find_all('#projectstable tbody tr')) > 0
             )
=20
         url =3D reverse('all-projects')
diff --git a/lib/toaster/tests/functional/test_project_page.py b/lib/toas=
ter/tests/functional/test_project_page.py
index 31177cc1..adbe3587 100644
--- a/lib/toaster/tests/functional/test_project_page.py
+++ b/lib/toaster/tests/functional/test_project_page.py
@@ -192,9 +192,10 @@ class TestProjectPage(SeleniumFunctionalTestCase):
         def test_show_rows(row_to_show, show_row_link):
             # Check that we can show rows =3D=3D row_to_show
             show_row_link.select_by_value(str(row_to_show))
-            self.wait_until_visible(f'#{table_selector} tbody tr', poll=3D=
2)
+            self.wait_until_visible(f'#{table_selector} tbody tr', poll=3D=
3)
+            # check at least some rows are visible
             self.assertTrue(
-                len(self.find_all(f'#{table_selector} tbody tr')) =3D=3D=
 row_to_show
+                len(self.find_all(f'#{table_selector} tbody tr')) > 0
             )
         self.wait_until_present(f'#{table_selector} tbody tr')
         show_rows =3D self.driver.find_elements(
diff --git a/lib/toaster/tests/functional/test_project_page_tab_config.py=
 b/lib/toaster/tests/functional/test_project_page_tab_config.py
index 03b0a854..eb905ddf 100644
--- a/lib/toaster/tests/functional/test_project_page_tab_config.py
+++ b/lib/toaster/tests/functional/test_project_page_tab_config.py
@@ -253,7 +253,7 @@ class TestProjectConfigTab(SeleniumFunctionalTestCase=
):
         def test_show_rows(row_to_show, show_row_link):
             # Check that we can show rows =3D=3D row_to_show
             show_row_link.select_by_value(str(row_to_show))
-            self.wait_until_visible('#imagerecipestable tbody tr')
+            self.wait_until_visible('#imagerecipestable tbody tr', poll=3D=
3)
             # check at least some rows are visible
             self.assertTrue(
                 len(self.find_all('#imagerecipestable tbody tr'))  > 0
--=20
2.34.1