RE: [AUH][PATCH v3 4/4] upgrade-helper.py: Add resume option to skip already attempted recipes

Yes, it was introduced by AI and I missed to catch it.

I did review it manually but clearly I need to be more focused to catch these types of issues.
The last thing I want is to waste maintainers time. You are very important for the project.
I apologize for that.

Best regards,
Daniel

> -----Original Message-----
> From: Alexander Kanavin <[email protected]>
> Sent: Tuesday, 5 May 2026 10:06
> To: Daniel Turull <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: Re: [AUH][PATCH v3 4/4] upgrade-helper.py: Add resume option to
> skip already attempted recipes
> 
> On Tue, 5 May 2026 at 08:49, Daniel Turull <[email protected]>
> wrote:
> > > > +            if 'workdir' in g:
> > > > +                if any(g['name'] == s['name'] for s in
> succeeded_pkggroups_ctx):
> > >
> > > This is more complex than the condition in the removed block below,
> > > why not use that:
> > >            if g in succeeded_pkggroups_ctx:
> > >
> > I'll add your suggestion.
> 
> Please be honest. Did AI introduce this inconsistency? Catching and correcting
> such things is on AI operators, not on reviewers.
> 
> Alex