Re: [PATCH wic 2/2] README.md: add Trevor (the maintainer)'s mail as Cc recipients

Quentin Schulz <[email protected]>
Newsgroups org.yoctoproject.lists.yocto-patches
Message-ID <[email protected]>
Hi Trevor,

On 6/11/26 2:48 PM, Trevor Woerner wrote:
> On Mon 2026-06-08 @ 12:47:59 PM, Quentin Schulz wrote:
>> From: Quentin Schulz <[email protected]>
>>
>> The instructions now match with the .b4-config file.
> 
> Sort of... I believe the b4 emails will read: "[PATCH wic]" while the
> cmdline emails will read: "[wic][PATCH]". No biggie, I'll find them
> either way.
> 

Details, details :D

I believe this is actually supported by b4, via the b4.send-presubject 
configuration knob, only available since b4 v0.15 (end of March 2026). 
Distros probably aren't all shipping this version and if using an 
earlier version it probably will do nothing. And we don't want both 
otherwise we'll get [PATCH wic][wic] when using v0.15+?

>> Suggested-by: Trevor Woerner <[email protected]>
>> Signed-off-by: Quentin Schulz <[email protected]>
>> ---
>>   README.md | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> Applied to wic, master branch. Thanks!
> 
>>
>> diff --git a/README.md b/README.md
>> index 0066ae4..3259019 100644
>> --- a/README.md
>> +++ b/README.md
>> @@ -57,9 +57,13 @@ When sending patches, please make sure the email subject line includes
>>   "[wic][PATCH]" and follow The Yocto Project community's patch submission
>>   guidelines.
>>   
>> +The patches should be sent with the mailing list ([email protected])
>> +in the To: recipients and the maintainer address ([email protected]) in Cc:
>> +recipients.
>> +
>>   When generating the patches manually, this will generate what's expected:
>>   
>> -   git send-email -M -1 --to [email protected] --subject-prefix='wic][PATCH'
>> +   git send-email -M -1 --to [email protected] --cc [email protected] --subject-prefix='wic][PATCH'
> 
> If my understanding is correct, in markdown, in order for this to be
> offset as a proper code block, it would need to be indented 4 spaces,
> not 3. Regardless this isn't relevant since we're not hosting (or
> mirroring) this project on github, and the markdown renderer on
> git.yoctoproject.org doesn't seem as in-sync with github's version of
> markdown. Either 4 spaces, or wrapped in ``` delimiters.
> 

Markdown is a PITA, you never know what's supported by whatever parser 
is used. Going for the "original" Markdown is probably best, but who's 
gonna check if the syntax is proper for new patches?

> In any case it doesn't look like the git.yoctoproject.org markdown
> renderer understands ```bash blocks, so I'm posting a follow-up patch to
> fix it all up.
> 

It seems like it could via an extension, c.f. 
https://python-markdown.github.io/extensions/fenced_code_blocks/#syntax-highlighting 
(if Archwiki doesn't lie on what markdown formatter is used by cgit).

Thanks for the fixup!

Cheers,
Quentin
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.