[wic][PATCH v2 1/4] oe/path: fix bare `false` NameError in __realpath's isdir guard
Trevor Woerner <[email protected]> Fri, 24 Jul 2026 07:50:17 -0400
| Newsgroups | org.yoctoproject.lists.yocto-patches |
|---|---|
| Message-ID | <[email protected]> |
__realpath() finishes by deciding whether the resolved path is a
directory, tolerating any error from the stat:
try:
is_dir = os.path.isdir(file)
except:
is_dir = false
but `false` is not a Python name -- the intended value is the builtin
False. os.path.isdir() swallows almost everything and simply returns
False for a path it cannot stat, so the except branch is rarely taken;
that is why the typo has stayed hidden. But when isdir() does raise --
for instance an OSError deep in os.stat() on a broken mount -- the
handler that was meant to absorb the error instead raises
NameError: name 'false' is not defined, masking the original failure
with a misleading one.
Use the builtin False so the fallback behaves as intended: a path that
cannot be stat'd is simply reported as not-a-directory.
AI-Generated: codex/claude-opus 4.8 (xhigh)
Signed-off-by: Trevor Woerner <[email protected]>
---
changes in v2:
- No change; carried over from v1.
---
src/wic/oe/path.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/wic/oe/path.py b/src/wic/oe/path.py
index 3e95ea0ec923..862edc532ade 100644
--- a/src/wic/oe/path.py
+++ b/src/wic/oe/path.py
@@ -233,7 +233,7 @@ def __realpath(file, root, loop_cnt, assume_dir):
try:
is_dir = os.path.isdir(file)
except:
- is_dir = false
+ is_dir = False
return (file, is_dir)
--
2.50.0.173.g8b6f19ccfc3a