Re: [yocto-autobuilder-helper][PATCH 11/11] config.json: containers-library: add mosquitto and valkey demos
Tim Orling <[email protected]> Mon, 11 May 2026 11:24:46 -0700
| Newsgroups | org.yoctoproject.lists.yocto,org.yoctoproject.lists.yocto-patches |
|---|---|
| Message-ID | <CAOyo-872MQ5CdFtLyhr7DVMyL_JpGWgmOV-SLQ-jy7nN++meeg@mail.gmail.com> |
On Mon, May 11, 2026 at 11:04 AM Tim Orling <[email protected]> wrote: > > > On Mon, May 11, 2026 at 2:00 AM Paul Barker <[email protected]> wrote: > >> On Thu, 2026-05-07 at 18:25 -0700, [email protected] wrote: >> > From: Tim Orling <[email protected]> >> > >> > Extend containers-library with two additional demo images sourced >> > from meta-yocto-containers-demo: >> > >> > * app-container-mosquitto: the Eclipse Mosquitto MQTT broker. >> > * app-container-valkey: Valkey (Redis-compatible) key/value datastore. >> > >> > Signed-off-by: Tim Orling <[email protected]> >> > --- >> > config.json | 12 ++++++++++++ >> > 1 file changed, 12 insertions(+) >> > >> > diff --git a/config.json b/config.json >> > index 7cdf91a..a9a2e9c 100644 >> > --- a/config.json >> > +++ b/config.json >> > @@ -1950,6 +1950,18 @@ >> > "BBTARGETS" : "app-container-python", >> > "CONTAINER_IMAGES" : {"app-container-python": >> "python"}, >> > "CONTAINER_VERSION_RECIPE" : "python3" >> > + }, >> > + "step2" : { >> > + "shortname" : "Build 'mosquitto' container", >> > + "BBTARGETS" : "app-container-mosquitto", >> > + "CONTAINER_IMAGES" : {"app-container-mosquitto": >> "mosquitto"}, >> > + "CONTAINER_VERSION_RECIPE" : "mosquitto" >> > + }, >> > + "step3" : { >> > + "shortname" : "Build 'valkey' container", >> > + "BBTARGETS" : "app-container-valkey", >> > + "CONTAINER_IMAGES" : {"app-container-valkey": >> "valkey"}, >> > + "CONTAINER_VERSION_RECIPE" : "valkey" >> >> This makes me wonder: can we build multiple app container images with >> one bitbake command? If so, can we combine these into one step? >> > > The getconfigdict() that was added to scripts/utils.py might make the JSON > definition of CONTAINER_IMAGES awkward as more containers are added, but it > "should" work. > > I had considered using a list of recipe names and building them in one > step, rather than a long 'bitbake <recipe 1> <recipe 2> ... <recipe N>' > command. This first attempt was kept simple. > > This would also impact pushing containers, as pushing is currently > appended as a step after 'build targets' when the push_containers boolean > is true. Container tooling needs to push one container at a time, which > will become more complicated with signing and attaching SLSA > attestations. This might be another use case for a list of container > recipes that can be iterated through. > > I'm open to another design if folks have better ideas for how the AB works. > > Capturing some additional thoughts I had on IRC: do we have any existing examples where a step iterates over a list in the AB? 11:10 AM I guess all the container recipes could be in BBTARGETS... but that list could get quite long as more container recipes are added... 11:13 AM maybe follow the ptest-packagelists.inc pattern 11:15 AM which then begs for BBCLASSEXTEND = "${@' '.join(['mcextend:'+x for x in d.getVar('PTESTS').split()])}" ;) > >> Best regards, >> >> -- >> Paul Barker >> >>