Re: [linux-safety] [PATCH] coccinelle: misc: Check for hard-coded constants
"Sudip Mukherjee" <[email protected]> Thu, 13 Aug 2020 16:41:15 +0100
| Newsgroups | tech.elisa.lists.linux-safety |
|---|---|
| Message-ID | <[email protected]> |
On 13/08/2020 16:33, Lukas Bulwahn wrote:
> Sorry for top posting.
>
>
>
> No, safety is CERTAINLY NOT a category. Security maybe, but even better
> would be a category like “information leaks” and a subset
> “kernel-internal information leaks” for your specific coccinelle rule
> addressing CWE-547.
>
>
>
> For me, for now, misc is okay, but if we want to restructure and
> clean-up, we should come up with a complete picture that fits for all.
imho, misc is ok for this one, but when you actually make a cocci script
for CWE-414 ("Missing Lock Check"), that should be going to
scripts/coccinelle/locks/
--
Regards
Sudip