Re: [linux-safety] [PATCH] misc: hisi_hikey_usb: use PTR_ERR_OR_ZERO

On Tue, 27 Oct 2020, Sudip Mukherjee wrote:

> Hi Lukas,
> 
> On 27/10/2020 05:36, Lukas Bulwahn wrote:
> > 
> > 
> > On Mon, 26 Oct 2020, Sudip Mukherjee wrote:
> > 
> >> Coccinelle suggested using PTR_ERR_OR_ZERO() and looking at the code,
> >> we can use PTR_ERR_OR_ZERO() instead of checking IS_ERR() and then
> >> doing 'return 0'.
> >>
> >> Signed-off-by: Sudip Mukherjee <[email protected]>
> >> ---
> 
> <snip>
> 
> > 
> > I think in the very long-term future, it would be nice if we can somehow 
> > link a finding from a specific tool (with some kind of URI) in the commit 
> > message or so.
> 
> I was thinking something almost similar, and was wondering if I can add
> the tool name with some tags and then it will be possible to generate
> some stats later about which tool fixed more things. I will send out a
> mail later today to lkml proposing that we use such a tag.
>
> I think adding URI is not possible until we have a persistent link to
> these reports. The report that I generate can only have last 4 days
> report, so the URI will not be valid after 4th day.
>

I would prefer to first include the reports into kernel ci db and maybe 
then we understand much better how to make those persistent links.

Lukas