Re: [linux-safety] [PATCH] scripts: Report 'suspicious' comments
"Mohammed Billoo" <[email protected]> Wed, 9 Sep 2020 19:45:03 -0400
| Newsgroups | tech.elisa.lists.linux-safety |
|---|---|
| Message-ID | <CALkjhPrJN-kB_UjuqZFpSaySyU6Q8mD7dCsP=ik4+itu=TWKcg@mail.gmail.com> |
> - Second, we then need to look into true and false positives here. > BUG appears in intended error messages, in DEBUG, in functions, such as > BUG, BUG_ON. So we need to collect the context around BUG and see to > improve the pattern to at least reduce the false positives. > I thought this was addressed in the Perl script. Did you find instances where this isn't the case (IIRC, BUG(), BUG_ON(), and anything else that is outside of a comment were ignored)? > - Third, we then need have suitable ways to aggregate the findings to know > which places are known to have many such findings and hence deserve some > kind of special care. > Do you think CodeChecker would be suitable for this? > And then, we need a lot of help to make proper evaluations what to do. Can you elaborate on this? I don't understand what you mean here. -- Mohammed A Billoo Founder MAB Labs, LLC www.mab-labs.com 201-338-2022