Re: [linux-safety] [PATCH] parse-sublevel-option.h : Add new line and license identifier

On Wed, Aug 18, 2021 at 7:01 PM Nghia Le <[email protected]> wrote:
>
> Add the new line at the end of file and add SPDX license identifier GPL-2.0, thus removing warning while running checkpatch.pl script
>
> Signed-off-by: Nghia Le <[email protected]>

Did you run checkpatch.pl on your own patch? What did it report?

> ---
>  tools/perf/util/parse-sublevel-options.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-sublevel-options.h b/tools/perf/util/parse-sublevel-options.h
> index 9b9efcc2aaad..bb44b5af2963 100644
> --- a/tools/perf/util/parse-sublevel-options.h
> +++ b/tools/perf/util/parse-sublevel-options.h
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +

Do you understand the legal implications of adding this annotation?
Are you among the authors to make this statement with sufficient
confidence?

It seems awkward to just annotate one file here, probably it is much
better to have one commit that adds this annotation to all files in
tools/perf/ if you are sure that this is all licensed GPL-2.0.

>  #ifndef _PERF_PARSE_SUBLEVEL_OPTIONS_H
>  #define _PERF_PARSE_SUBLEVEL_OPTIONS_H
>
> @@ -8,4 +10,5 @@ struct sublevel_option {
>
>  int perf_parse_sublevel_options(const char *str, struct sublevel_option *opts);
>
> -#endif
> \ No newline at end of file
> +#endif
> +

Now, you are adding an empty new line to this file. Can you create a
patch that ends with #endif and a newline instead? That seems much
more common throughout the whole kernel tree.

Good luck, we are anxiously waiting for your patch v2.

Lukas


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#241): https://lists.elisa.tech/g/linux-safety/message/241
Mute This Topic: https://lists.elisa.tech/mt/84977020/5278000
Group Owner: [email protected]
Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-