Re: [linux-safety] [PATCH v2] parse-sublevel-options.h : Add missing newline

For the subject line: the prefix should probably be "tools: perf:
...", but not "parse-sublevel-options.h:". Use git log --oneline
tools/perf to find the most common convention for commits to
tools/perf.

On Thu, Aug 19, 2021 at 12:05 PM Nghia Le <[email protected]> wrote:
>
> Add missing newline at the end of file, thus removing relevant warning
> reported by checkpatch.pl
>

You can just write "checkpatch" instead of checkpatch.pl. And end your
sentences with ".".

Always run checkpatch.pl on your patch. But there is no need to add
the checkpatch report in the commit message.


> Checkpatch.pl reported for patch as below:
>
> total: 0 errors, 0 warnings, 6 lines checked
>
> v2-0001-parse-sublevel-options.h-Add-missing-newline.patch has no obvious
> style problems and is ready for submission.
>
> Signed-off-by: Nghia Le <[email protected]>
> ---
>  tools/perf/util/parse-sublevel-options.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-sublevel-options.h b/tools/perf/util/parse-sublevel-options.h
> index 9b9efcc2aaad..578b18ef03bb 100644
> --- a/tools/perf/util/parse-sublevel-options.h
> +++ b/tools/perf/util/parse-sublevel-options.h
> @@ -8,4 +8,4 @@ struct sublevel_option {
>
>  int perf_parse_sublevel_options(const char *str, struct sublevel_option *opts);
>
> -#endif
> \ No newline at end of file
> +#endif

Change looks good now. I suggest you send a patch v3 here and if that
is all good, it is probably ready for the general mailing list.

Lukas


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#244): https://lists.elisa.tech/g/linux-safety/message/244
Mute This Topic: https://lists.elisa.tech/mt/84993288/5278000
Group Owner: [email protected]
Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-