[linux-safety] [PATCH] mm/hugetlb.c: remove deadstore in demote_size_show()

"Nghia Le" <[email protected]> Sat, 2 Oct 2021 00:57:32 +0700
Newsgroups tech.elisa.lists.linux-safety
Message-ID <20211001175732.AGaY1ihCJUgisiljxXXFQZ-fD6lRBxuG4r2jemW6G58@z>
Deadstore was detected by CodeCheck tool (ELISA group)

Removed demote_size and relevant assignment in function demote_size_show()
to fix deadstore issue of which stored value to demote_size is never read

Signed-off-by: Nghia Le <[email protected]>
---
 mm/hugetlb.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 993efa70bce4..ef00e6ad0f6a 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -3706,11 +3706,9 @@ static ssize_t demote_size_show(struct kobject *kobj,
 					struct kobj_attribute *attr, char *buf)
 {
 	struct hstate *h;
-	unsigned long demote_size;
 	int nid;
 
 	h = kobj_to_hstate(kobj, &nid);
-	demote_size = h->demote_order;
 
 	return sysfs_emit(buf, "%lukB\n",
 			(unsigned long)(PAGE_SIZE << h->demote_order) / SZ_1K);
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#247): https://lists.elisa.tech/g/linux-safety/message/247
Mute This Topic: https://lists.elisa.tech/mt/86006510/5278000
Group Owner: [email protected]
Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-