Re: [linux-safety] [PATCH v2] ext4: remove useless resetting io_end_size in mpage_process_page()
"Nghia Le" <[email protected]> Tue, 26 Oct 2021 05:25:56 +0700
| Newsgroups | tech.elisa.lists.linux-safety |
|---|---|
| Message-ID | <20211025222556.bC2XwTOnnVmeV_TqhtHrRheeB7eoPmj58U40tikCD7g@z> |
--000000000000e05c3805cf34d81c Content-Type: text/plain; charset="UTF-8" Hi Lukas, Thanks a lot for your comments, I fixed typos and submitted patch to public mailing list. Best regards, Nghia Le On Mon, Oct 25, 2021 at 10:49 PM Lukas Bulwahn <[email protected]> wrote: > On Thu, Oct 21, 2021 at 7:43 PM Nghia Le <[email protected]> wrote: > > > > The command "make clang-analyzer" detects dead stores. > > maybe mention that it detects dead stores in mpage_process_page(). > > > > > Do not reset io_end_size to 0 in the current paths, as the function > > exists on those paths wihout further using io_end_sized. > > just a few typo: > > s/exists/exits/ > s/wihout/without/ > s/io_end_sized/io_end_size/ > > So far it looks good. Can you correct those minor points above and > then we should be fine... > > Lukas > > > > > Signed-off-by: Nghia Le <[email protected]> > > --- > > fs/ext4/inode.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > > index 0f06305167d5..03efed2ed1ea 100644 > > --- a/fs/ext4/inode.c > > +++ b/fs/ext4/inode.c > > @@ -2260,7 +2260,6 @@ static int mpage_process_page(struct mpage_da_data > *mpd, struct page *page, > > mpd->map.m_len = 0; > > mpd->map.m_flags = 0; > > io_end_vec->size += io_end_size; > > - io_end_size = 0; > > > > err = mpage_process_page_bufs(mpd, head, bh, > lblk); > > if (err > 0) > > @@ -2285,7 +2284,6 @@ static int mpage_process_page(struct mpage_da_data > *mpd, struct page *page, > > } while (lblk++, (bh = bh->b_this_page) != head); > > > > io_end_vec->size += io_end_size; > > - io_end_size = 0; > > *map_bh = false; > > out: > > *m_lblk = lblk; > > -- > > 2.25.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#257): https://lists.elisa.tech/g/linux-safety/message/257 Mute This Topic: https://lists.elisa.tech/mt/86495840/5278000 Group Owner: [email protected] Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=- --000000000000e05c3805cf34d81c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Hi Lukas,<div>Thanks a lot for your comments, I fixed typo= s and submitted patch to public mailing list.</div><div>Best regards,</div>= <div>Nghia Le</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" cl= ass=3D"gmail_attr">On Mon, Oct 25, 2021 at 10:49 PM Lukas Bulwahn <<a hr= ef=3D"mailto:[email protected]">[email protected]</a>> wrote= :<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.= 8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu, Oct 21= , 2021 at 7:43 PM Nghia Le <<a href=3D"mailto:[email protected]" targe= t=3D"_blank">[email protected]</a>> wrote:<br> ><br> > The command "make clang-analyzer" detects dead stores.<br> <br> maybe mention that it detects dead stores in mpage_process_page().<br> <br> ><br> > Do not reset io_end_size to 0 in the current paths, as the function<br= > > exists on those paths wihout further using io_end_sized.<br> <br> just a few typo:<br> <br> s/exists/exits/<br> s/wihout/without/<br> s/io_end_sized/io_end_size/<br> <br> So far it looks good. Can you correct those minor points above and<br> then we should be fine...<br> <br> Lukas<br> <br> ><br> > Signed-off-by: Nghia Le <<a href=3D"mailto:[email protected]" tar= get=3D"_blank">[email protected]</a>><br> > ---<br> >=C2=A0 fs/ext4/inode.c | 2 --<br> >=C2=A0 1 file changed, 2 deletions(-)<br> ><br> > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c<br> > index 0f06305167d5..03efed2ed1ea 100644<br> > --- a/fs/ext4/inode.c<br> > +++ b/fs/ext4/inode.c<br> > @@ -2260,7 +2260,6 @@ static int mpage_process_page(struct mpage_da_da= ta *mpd, struct page *page,<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0mpd->map.m_len =3D 0;<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0mpd->map.m_flags =3D 0;<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0io_end_vec->size +=3D io_end_size;<br> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0io_end_size =3D 0;<br> ><br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0err =3D mpage_process_page_bufs(mpd, head, bh, lblk);<b= r> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0if (err > 0)<br> > @@ -2285,7 +2284,6 @@ static int mpage_process_page(struct mpage_da_da= ta *mpd, struct page *page,<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} while (lblk++, (bh =3D bh->b_thi= s_page) !=3D head);<br> ><br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0io_end_vec->size +=3D io_end_size;= <br> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0io_end_size =3D 0;<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*map_bh =3D false;<br> >=C2=A0 out:<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*m_lblk =3D lblk;<br> > --<br> > 2.25.1<br> ><br> </blockquote></div> <div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div> <hr> L= inks:<p> You receive all messages sent to this group. <p> <a target=3D= "_blank" href=3D"https://lists.elisa.tech/g/linux-safety/message/257">View/= Reply Online (#257)</a> | <a target=3D"_blank" href=3D"mailto:nghialm78@gm= ail.com?subject=3DPrivate:%20Re:%20Re%3A%20%5Blinux-safety%5D%20%5BPATCH%20= v2%5D%20ext4%3A%20remove%20useless%20resetting%20io_end_size%20in%20mpage_p= rocess_page%28%29">Reply To Sender</a> | <a target=3D"_blank" href=3D"mail= to:[email protected]?subject=3DRe:%20Re%3A%20%5Blinux-safety%5D= %20%5BPATCH%20v2%5D%20ext4%3A%20remove%20useless%20resetting%20io_end_size%= 20in%20mpage_process_page%28%29">Reply To Group</a> | <a target=3D"_blan= k" href=3D"https://lists.elisa.tech/mt/86495840/5278000">Mute This Topic</a= > | <a href=3D"https://lists.elisa.tech/g/linux-safety/post">New Topic</a>= <br> <a href=3D"https://lists.elisa.tech/g/linux-safety/editsub/5278000"= >Your Subscription</a> | <a href=3D"mailto:[email protected]= ech">Contact Group Owner</a> | <a href=3D"https://lists.elisa.tech/g/linux= -safety/unsub">Unsubscribe</a> [[email protected]]<br> <div= width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div>=20 --000000000000e05c3805cf34d81c--