[linux-safety] [PATCH] ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()
"Nghia Le" <[email protected]> Thu, 4 Nov 2021 06:27:22 +0700
| Newsgroups | tech.elisa.lists.linux-safety |
|---|---|
| Message-ID | <20211103232722.rWvvanakj0byG7NJOVN18fHkWZHSx2_TVcpPKWmiYHw@z> |
The newinet value is initialized with inet_sk() in a block code starting from checking condition of protocol to exiting by returning newsk structure. Along the code path, newinet is never read. Thus, assignment to newinet is wredundant and can be removed. Signed-off-by: Nghia Le <[email protected]> --- net/ipv6/tcp_ipv6.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index 2cc9b0e53ad1..551fce49841d 100644 --- a/net/ipv6/tcp_ipv6.c +++ b/net/ipv6/tcp_ipv6.c @@ -1263,7 +1263,6 @@ static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk, struct sk_buff * inet_sk(newsk)->pinet6 = tcp_inet6_sk(newsk); - newinet = inet_sk(newsk); newnp = tcp_inet6_sk(newsk); newtp = tcp_sk(newsk); -- 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#261): https://lists.elisa.tech/g/linux-safety/message/261 Mute This Topic: https://lists.elisa.tech/mt/86805127/5278000 Group Owner: [email protected] Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-