Re: [PATCH -next for tip:x86/pti] x86/tlb: drop unneeded local vars in enable_l1d_flush_for_task()
Peter Zijlstra <[email protected]> Thu, 1 Oct 2020 10:19:58 +0200
| Newsgroups | tech.elisa.lists.linux-safety,org.kernel.vger.kernel-janitors,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Your MUA is having trouble wrapping text at 78 chars. On Thu, Oct 01, 2020 at 09:49:30AM +1000, Singh, Balbir wrote: > So this is the change I am playing with, I don't like the idea of > killing the task, but it's better than silently not flushing, I guess > system administrators will learn with time not to correctly the > affinity of tasks flushing L1D. For the affinity bits, not being able > to change the affinity is better, but not being able to provide > feedback on as to why is a bit weird as well, but I wonder if there > are other cases where we might want to lock the affinity of a task for > it's lifetime. You can't really do that, hot-unplug can (and will) destroy any affinity setting, and if the task/admin wants to recover it needs to be able to re-set affinity after that.