Re: [PATCH] usb: host: ehci-sched: avoid possible NULL dereference

"Harley A.W. Lorenzo" <[email protected]> Mon, 05 Oct 2020 23:19:02 +0000
Newsgroups tech.elisa.lists.linux-safety,org.kernel.vger.linux-kernel,org.kernel.vger.linux-usb
Message-ID <brWYeL8miTAikvEPYFNe2Kpe05OBtiD6yuS6jRg1VCX-lt7ANc1B2y7AM6ECEoG9AJwZP5_5qoGO7POvK0MtruvqG8q8kHbyHiOUIZ72Klk=@protonmail.com>
On Monday, October 5, 2020 5:31 PM, Sudip Mukherjee <[email protected]> wrote:

> find_tt() can return NULL or the error value in ERR_PTR() and
> dereferencing the return value without checking for the error can
> lead to a possible dereference of NULL pointer or ERR_PTR().

Looks fine to me. There is in fact no checks of the return value
before a dereference here, and this solves that.

Reviewed-by: Harley A.W. Lorenzo <[email protected]