Re: Test-Smoke-1.03

On Tue, Aug 28, 2001 at 10:26:35AM +0200, H . Merijn Brand wrote:
> Beta. Stil under review. Not tested. Need feedback. (etc, enough warnings?)

This is a cut&paste patch, so you'll need to --ignore-whitespace
My hack of adding a "=" to the end of the file to simplify the coding
later means that there's a read only value in $_ at one point, and the s///
will fail.

[eg perl -le 'foreach ("=") {s/foo/bar/}'
Modification of a read-only value attempted at -e line 1.
]

--- mktest.pl~  Mon Aug 27 10:49:19 2001
+++ mktest.pl   Tue Aug 28 11:41:07 2001
@@ -60,7 +60,7 @@
     # Cheat. Force a break marker as a line after the last line.
     foreach (<CONF>, "=") {
        m/^#/ and next;
-       s/\s+$//;       # Blanks, new-lines and carriage returns. M$
+       s/\s+$// if /\s/;       # Blanks, new-lines and carriage returns. M$
        if (m:^/:) {
            m:^/(.*)/$:;
            defined $1 or die "Policy target line didn't end with '/': '$_'";


5.005_03 issues a warning about assigning undef to a typeglob at this line:

        local ($/, *POL) = (undef);

I think that re-writing it as

        local ($/, *POL);

will avoid the warning, but as it's running I don't want to change it.

Otherwise, it seems to smoke quite nicely.

Nicholas Clark