Announce Test-Smoke-1.10

On Mon 05 Nov 2001 16:29, Abigail <[email protected]> wrote:
> Just downloaded Test::Smoke, and I found a few problems with Makefile.PL,
> all related to cron.
> 
> 1)  It assumes the cron deamon is called 'cron', but some operating
>     systems use 'crond'. Also, sometimes the daemon is started with
>     options.

Took your input to change it.

> 2)  Some operating systems use the program 'crontab' to actually set
>     entries.

Was solved in 1.09

> 3)  The file 'cron.tab' was never written to.

Was solved in 1.09

> This patch fixes the problems.
> 
> 
> Also, http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/~checkout~/perl-qa/smoke/README?rev=HEAD&content-type=text/plain
> refers to http://home.hccnet.nl/h.m.brand/Test-Smoke-1.09.tgz and
> $CPAN/authors/id/H/HM/HMBRAND/Test-Smoke-1.09.tgz, but I haven't been 
> able to find anything newer than 1.08.

D'uh! I've updated it to CVS and to (probably) a selected list of people.
The just released now 1.10 is attached. Now I have to dig in CVS again :((
which I will do ASAP

	http://home.hccnet.nl/h.m.brand/Test-Smoke-1.10.tgz
or	$CPAN/authors/id/H/HM/HMBRAND/Test-Smoke-1.10.tgz

within moments from now

From the ChangeLog:

*** Release 1.10

    Wed 05 Nov 2001, Merijn

        - cron sometimes runs as crond, possibly with options (Abigail)
        - Included $Config{osvers} in the report

*** Release 1.09

    Wed 26 Sep 2001, Merijn

	- Removed depricated perl.ok and perl.nok file stuff
	  harness log now printed to LOG :)
	- added the missing is_win32 () function
	- smoke.cfg less default than previous default (Blair)
	- ask for umask, also enable 'none'
	- log harness to the log, not to out
	- actually *write* the cron we've prepared (Schwern)
	- use crontab to (re)submit the new crontab instead of cron (Schwern)
	- 'ps -f' doesn't work on Mac (Schwern)

> Abigail
> 
> --- Makefile.PL.orig	Mon Nov  5 16:06:27 2001
> +++ Makefile.PL	Mon Nov  5 16:21:58 2001
> @@ -85,7 +85,7 @@
>  
>  open STDERR, ">&STDOUT";
>  my $time = "random";
> -if (grep m/cron$/, `ps -ef`) {
> +if (grep m/crond?\b/, `ps -ef`) {
>      my ($m, $h);
>      while (1) {
>  	print "At what time do you want the smoke to start ?\n";
> @@ -107,11 +107,27 @@
>  	      (map { "  $_" } @cron),
>  	      "Shall I use it? [Y/n] > Y\b";
>  	unless (scalar <STDIN> =~ m/^[NnFf0]/) { # No, Nee, Nein, Non, False, 0
> -	    open CRON, "> cron.tab" or die "cron.tab: $!";
> -	    system "cron cron.tab";
> -	    unlink "cron.tab";
> +            my $cron;
> +          DIRS:
> +            foreach my $dir (split /:/ => $ENV {PATH}) {
> +                foreach my $try (qw /cron crontab/) {
> +                    next unless -x "$dir/$try";
> +                    $cron = "$dir/$try";
> +                    last DIRS;
> +                }
> +            }
> +            if ($cron) {
> +                open CRON, "> cron.tab" or die "cron.tab: $!";
> +                print CRON @cron;
> +                close CRON or die "Failed to close cron.tab: $!";
> +                system "$cron cron.tab";
> +                unlink "cron.tab" or die "Failed to cleanup cron.tab: $!";
>  	    }
> +            else {
> +                warn "Failed to find a `cron' or `crontab' program!\n";
> +            }
>  	}
> +    }
>      else {
>  	print "Cannot read current crontab\n";
>  	}

-- 
H.Merijn Brand    Amsterdam Perl Mongers (http://www.amsterdam.pm.org/)
using perl-5.6.1, 5.7.2 & 629 on HP-UX 10.20 & 11.00, AIX 4.2, AIX 4.3,
  WinNT 4, Win2K pro & WinCE 2.11.  Smoking perl CORE: [email protected]
http://archives.develooper.com/[email protected]/   [email protected]
send smoke reports to: [email protected], QA: http://qa.perl.org