Re: Trouble with Test::Smoke 1.12

On Thursday, April 11, 2002, at 03:14  PM, H.Merijn Brand wrote:

> On Thu 11 Apr 2002 14:43, Kay Roepke <[email protected]> wrote:
>>   Tests start here:
>> PERLIO = stdio  /bin/sh: TEST: command not found
>
> not harmless, but easy to solve. '.' is not in your $PATH

Well, true.

> Either
> 1. Put '.' in $PATH in smoke.sh
>
> 	export PATH=.:$PATH
>
> 2. Put '.' in $ENV{PATH} in mktest.pl
>
> 	$ENV{PATH} .= ":.";
>
> Security issues are being discussed. Might also be `solved' in the 
> bleadperl
> distribution itself.

Sorry, but I ignorantly fail to see why I should have to do that. ;-)

As a quick look a mktest.pl and perls Makefile show, the $(PERL) 
variable is empty, forcing make to execute /bin/sh -c TEST in 
perl-current/t/ which fails (for me at least).

My first guess was to patch perls Makefile.SH to call its TESTFILE 
../TEST rather than just TEST, but I'm not sure of the implications (are 
there any? Windows? VMS? whatever?). (Patch attached)



The other solution would be to educate mktest.pl to call 'make _test' 
with the right $(PERL).  (See the second attachment.)



Have the appropriate amount of fun selecting the most pleasing patch ;-).


Regards,

Kay

--- Makefile.SH.orig	Thu Apr 11 15:28:50 2002
+++ Makefile.SH	Thu Apr 11 15:29:23 2002
@@ -989,7 +989,7 @@
 # Cannot delegate rebuilding of t/perl to make
 # to allow interlaced test and minitest
 
-TESTFILE=TEST
+TESTFILE=./TEST
 
 _test_prep:
 	cd t && (rm -f $(PERL)$(EXE_EXT); $(LNS) ../$(PERL)$(EXE_EXT) $(PERL)$(EXE_EXT))

--- mktest.pl	Mon Mar  4 12:05:59 2002
+++ /home/kroepke/packages/Test-Smoke-1.12/mktest.pl	Thu Apr 11 16:50:12 2002
@@ -349,7 +349,7 @@
 		chdir ".." or die "unable to chdir () out of 'win32'";
 		}
 	    else {
-		open TST, "make _test |";
+		open TST, "PERL=./perl make _test |";
 		}
 
 	    my @nok = ();