Re: Sanity check please: minor hack to mktest.pl

Op een zonnige zomerdag (Monday 11 August 2003 16:59), schreef Alan Burlison:

> I've a suspicion that the test failures I have been seeing on Solaris are
> because 'make test' is being run with parallel make instead of serial make.
>   I don't want to switch entirely to serial make because the builds already
> take a long time.  I've therefore hacked mktest.pl to use /usr/ccs/bin/make
> for the 'make _test' step only - can someone confirm that I haven't missed
> any other places that need changing?

Yup , you have missed the place that is actually used, that is if you use 
standard Test::Smoke (smokeperl.pl).

F<mktest.pl> is deprecated and unsupported as of 1.18, you'll want to change 
that in Test::Smoke::Smoker::make_test() [line 394ish]

I think this is a reasonable request, so I am willing to hack you a 
configurable "make" for testing if you like.

To make use of this patch after applying, just put a

	testmake => '/usr/ccs/bin/make',

in your *_config files.

If you like this, I'll commit it to the repository:

Index: lib/Test/Smoke/Smoker.pm
===================================================================
--- lib/Test/Smoke/Smoker.pm    (revision 347)
+++ lib/Test/Smoke/Smoker.pm    (working copy)
@@ -27,6 +27,7 @@
     df_w32args        => [ ],

     df_makeopt        => "",
+    df_testmake       => 'make',
 );

 # Define some constants that we can use for
@@ -391,7 +392,7 @@
             chdir ".." or die "unable to chdir () out of 'win32'";
         } else {
             local $ENV{PERL} = "./perl";
-            open TST, "make $test_target |" or do {
+            open TST, "$self->{testmake} $test_target |" or do {
                 use Carp;
                 Carp::carp "Cannot fork 'make _test': $!";
                 next;


Good luck,

Abe
-- 
Unspecified = it may work or it may not or demons may fly out of your nose. 
And the hairyness of the demons is almost guaranteed to vary from platform
to platform.
                                   -- Jarkko Hietaniemi on p5p @ 2001-12-10