Re: patch to add support for make options to Test::Smoke

Op een zonnige zomerdag (Monday 11 August 2003 20:36), schreef KIDDER, ERIC J 
(SBCSI):

> Patch to allow make options (I hope):

Many thanks for a good patch, but I'm afraid, I beat you to it (changes 
347/370)...

> +     make_opt => {

I called it "makeopt"


>           # Sync related
>           qw( sync_type fsync rsync opts source tar server sdir sfile
> !             patchup pserver pdir unzip patch cleanup cdir hdir patch
> pfile make_opt ),

I put it together with Alan's "testmake" in their own section

> --- 308,314 ----
>       my $self = shift;
>
>       $self->tty( "\nmake ..." );
> !     $self->_make( "$self->{make_opt}" );

Is this really the only place you the options active?
I put it in Test::Smoke::Smoker::_make() like:

 sub _make {
     my $self = shift;
     my $cmd = shift;
+    $self->{makeopt} and $cmd = "$self->{makeopt} $cmd";

Do you think that is too much? (Will not be used for "make _test")

I'd like opinion on this smokers.

Good luck,

Abe
-- 
Documenting bugs before they're found is kinda hard. 
Can I borrow your time machine? Mine won't start.
                                  -- Michael G. Schwern on p5p @ 2002-11-19