Minor snag in mktest.pl
[email protected] ("H.Merijn Brand")
| Newsgroups | perl.daily-build |
|---|---|
| Message-ID | <[email protected]> |
On Thu 09 Aug 2001 05:15, Michael G Schwern <[email protected]> wrote: > I'm getting false negatives because for some reason @nok contains some extra junk: > > DB<5> p @nok > sh mv-if-diff configpm.tmp lib/Config.pm > File lib/Config.pm not changed. > make TEST_ARGS= TESTFILE=TEST _test_tty ; \ > make TEST_ARGS= TESTFILE=TEST _test_notty ; \ These should be filtered out in the mktest script. Haven't done that (yet) > All tests successful. > > So it looks for /All tests successful/ in $nok[0] and doesn't find it. > I don't know why that extra stuff is showing up for me and not you. > > Anyhow, I'm going to change it to grep /^All tests successful/, @nok. See comments in other mail to Nick As long as the mkovz.pl is creating the report, do we still need the perl.ok and perl.nok files, or should I strip that out also, maybe even put the mkovz stuff inside mktest and remove mkovz.pl, only leaving three files to the module: mktest, smoke.sh, and README If that's what we're heading for, I could turn that into a module and create a Makefile.PL and a MANIFEST and have the Makefile.PL ask the questions 'bout the location for perl-current and the mail-address to send the reports to. -- H.Merijn Brand Amsterdam Perl Mongers (http://www.amsterdam.pm.org/) using perl-5.6.1, 5.7.1 & 623 on HP-UX 10.20 & 11.00, AIX 4.2, AIX 4.3, WinNT 4, Win2K pro & WinCE 2.11 often with Tk800.022 &/| DBD-Unify ftp://ftp.funet.fi/pub/languages/perl/CPAN/authors/id/H/HM/HMBRAND/