Re: Smoke [5.8.6] 23484 FAIL(X) MSWin32 WinXP/.Net SP1 (x86/1 cpu)

On Mon 08 Nov 2004 22:59, Abe Timmerman <[email protected]> wrote:
> > I have noticed that 'X's also come from "skip" failed tests.
> > These are more a warning than a failure, if warning at all.
> 
> IMO skipped tests shouldn't fail. Either the test is skipped (not executed) 
> and thus PASS or it is a TODO test. That way everybody knows it is no 
> surprise that the test fails (or passes).

--- TS-1.19/lib/Test/Smoke/Util.pm	2004-07-23 12:49:08.000000000 +0200
+++ smoke/Test/Smoke/Util.pm	2004-11-17 10:45:52.068855352 +0100
@@ -876,6 +876,7 @@ sub skip_filter {
     m,^File::Temp::_gettemp: Parent directory \((\.|/tmp/)\) is not safe, ||
     m,^ok$, ||
     m,^[-a-zA-Z0-9_/]+\.*(ok|skipping test on this platform)$, ||
+    m,^(not\s+)?ok\s+\d+\s+[-#]\s+(?i:(todo|skip\S*)[: ]), ||
     m,^(xlc|cc_r) -c , ||
 #    m,^\s+$testdir/, ||
     m,^sh mv-if-diff\b, ||

-- 
H.Merijn Brand        Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using perl-5.6.1, 5.8.5, & 5.9.x, and 809 on  HP-UX 10.20 & 11.00, 11i,
   AIX 4.3, AIX 5.2, SuSE 9.1, and Win2k.  http://www.cmve.net/~merijn/
http://archives.develooper.com/[email protected]/   [email protected]
send smoke reports to: [email protected], QA: http://qa.perl.org