Re: [Dbdpg-general] statistics_info patch

On 12/1/06, Greg Sabino Mullane <[email protected]> wrote:
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>
> > As you might've seen on the dbi-dev list, I've just gotten a new
> > patch (attached here as well for reference) for a new info interface
> > "statistics_info" added to the svn version of DBI.pm.
> >
> > Attached here is an implementation of this interface as a patch
> > against DBD::Pg cvs for your review.  Let me know if you'd like me to
> > change/fix/improve/etc anything wrt to this patch
>
> Looks good: the patch is now applied. Thank you.
>
> Sorry for the long delay, DBD::Pg development should be kicking into
> high gear once again.
>

Excellent, many thanks :)

Incidentally, at some point since I submitted this, I noticed a minor
bug in the tests included in my patch.  I don't have access to the
repo at this moment for a proper patch, but it's a very simple change.

In t/03dbmethod.t, the line I added that reads:

       skip qq{Cannot test statistics_info with schema arg on pre-7.3
servers.}, 3

Should read:

       skip qq{Cannot test statistics_info with schema arg on pre-7.3
servers.}, 4

(I guess I didn't update it when I added a 4th test to that block at
some point).

-- Brandon