[svn:dbi] r14189 - in dbi/trunk/lib: DBD DBI/DBD

Author: REHSACK
Date: Mon Jun 28 05:12:23 2010
New Revision: 14189

Modified:
   dbi/trunk/lib/DBD/File.pm
   dbi/trunk/lib/DBI/DBD/SqlEngine.pm

Log:
remove depreciated code


Modified: dbi/trunk/lib/DBD/File.pm
==============================================================================
--- dbi/trunk/lib/DBD/File.pm	(original)
+++ dbi/trunk/lib/DBD/File.pm	Mon Jun 28 05:12:23 2010
@@ -369,8 +369,6 @@
 	my ( undef, $meta ) = $class->get_table_meta ($dbh, $table, 1);
     $meta or ($meta = {} and $class->bootstrap_table_meta ($dbh, $meta, $table));
 
-    my $dbd_file_verinfo = $dbh->{f_version};
-
     my $dver;
     my $eval_str;
     $eval_str = sprintf ('$dver = $%s::VERSION', "IO::File");

Modified: dbi/trunk/lib/DBI/DBD/SqlEngine.pm
==============================================================================
--- dbi/trunk/lib/DBI/DBD/SqlEngine.pm	(original)
+++ dbi/trunk/lib/DBI/DBD/SqlEngine.pm	Mon Jun 28 05:12:23 2010
@@ -746,7 +746,7 @@
 
 sub finish
 {
-    my $sth = shift;
+    my $sth = $_[0];
     $sth->SUPER::STORE( Active => 0 );
     delete $sth->{sql_stmt}{data};
     return 1;
@@ -754,7 +754,7 @@
 
 sub fetch ($)
 {
-    my $sth  = shift;
+    my $sth  = $_[0];
     my $data = $sth->{sql_stmt}{data};
     if ( !$data || ref $data ne "ARRAY" )
     {
@@ -780,8 +780,6 @@
 
 use warnings;
 
-my %unsupported_attrib = map { $_ => 1 } qw( TYPE PRECISION );
-
 sub sql_get_colnames
 {
     my $sth = $_[0];
@@ -807,21 +805,23 @@
 sub FETCH ($$)
 {
     my ( $sth, $attrib ) = @_;
-    exists $unsupported_attrib{$attrib}
-      and return;    # Workaround for a bug in DBI 0.93
+
     $attrib eq "NAME"
       and return [ $sth->sql_get_colnames() ];
+
     if ( $attrib eq "NULLABLE" )
     {
         my @colnames = $sth->sql_get_colnames();
         @colnames or return;
         return [ (1) x @colnames ];
     }
+
     if ( $attrib eq lc $attrib )
     {
         # Private driver attributes are lower cased
         return $sth->{$attrib};
     }
+
     # else pass up to DBI to handle
     return $sth->SUPER::FETCH($attrib);
 }    # FETCH
@@ -829,11 +829,8 @@
 sub STORE ($$$)
 {
     my ( $sth, $attrib, $value ) = @_;
-    exists $unsupported_attrib{$attrib}
-      and return;    # Workaround for a bug in DBI 0.93
-    if ( $attrib eq lc $attrib )
+    if ( $attrib eq lc $attrib ) # Private driver attributes are lower cased
     {
-        # Private driver attributes are lower cased
         $sth->{$attrib} = $value;
         return 1;
     }