Re: [PATCH] Bug fix for storing shared objects in shared structures
[email protected] ("Rafael Garcia-Suarez") Thu, 8 Nov 2007 11:34:15 +0100
| Newsgroups | perl.perl5.porters,perl.ithreads |
|---|---|
| Message-ID | <[email protected]> |
On 06/11/2007, Jerry D. Hedden <[email protected]> wrote: > On 11/6/07, Rafael Garcia-Suarez <[email protected]> wrote: > > On 06/11/2007, Jerry D. Hedden <[email protected]> wrote: > > > The attached patches fix this bug. Thank to Dean Arnold for the > > > suggestion to use a PL_ function pointer. > > > > OK. The blead.patch can go in without problems: it does nothing and > > prepares binary compatibilty for upcoming 5.10.x and upcoming CPAN > > releases of threads::shared. But the shared.patch itself might be a > > bit dangerous to put in bleadperl this late, knowing that it could > > always be upgraded from CPAN ? What do you think ? > > I plan to release the updated threads::shared to CPAN if you > incorporate these patches into blead. However, there is no > compatibility issues: the two patches will work with or without each > other. You can see this by noting the #ifdef PL_destroyhook in > shared.xs. OK, I've applied the blead.patch part as #32241 to bleadperl.