Re: Patch for JNI modules Makefile.PL

On Mon, Jul 17, 2000 at 04:37:49PM -0600, Jens Thomsen wrote:
> I found a problem in the Makefile.PL in the jpl/JNI directory of the perl
> source tree and this should patch it. The problem was that it would find
> the green_thread directory before native threads on linux.
> 
> 98c98
> <     CCFLAGS => "$Config{ccflags} $CCFLAGS -O2", 
> ---
> >     CCFLAGS => "$Config{ccflags} $CCFLAGS", 

Why drop the optimizing?  Maybe $Config{optimize} would be okay?

> 121,122c121,123
> <             if (/$name$/ and ! /green_threads/ and !/include-old/) {
> <                     $lib = $File::Find::name;
> ---
> >             $pos = $File::Find::name;
> >             if (/$name$/ && $pos !~ /green_threads/ && $pos !~ /include-old/) {
> > 		$lib = $pos;
> 
> 
> P.S. This is my first patch I have submitted so if it is not in the right
> format let me know how to format it correctly.

diff -u (if your diff support that) and diff -c (all diffs should
support that) are generaly preferable to 'raw' diff because line
numbers may changed and seeing more context is nice.

-- 
$jhi++; # http://www.iki.fi/jhi/
        # There is this special biologist word we use for 'stable'.
        # It is 'dead'. -- Jack Cohen