Re: libwin32 commit bit?

Le 22 septembre 2010 19:50, Jan Dubois <[email protected]> a écrit :

> Hi Olivier,
>
> I’ve added you to the project member list, so you should have write
> access to the repository now.
>

Thanks. jan++


> Thank you for the Win32::EventLog patch and especially for the added test!
>

The testsuite is the area I plan to contibute the most for libwin32.

You have probably noticed that I didn’t apply all of your Win32::Daemon
> changes. I did want to release the sources as close as possible to the
> way I got the initial drop from Dave (although it did require some
> massive refactoring to isolate the code from the rest of his modules,
> and make it build with MakeMaker).
>

I'm glad to now be able to install Win32::Daemon on Strawberry Perl !
Thanks!

I would prefer to have doc changes, or source reformatting as separate
> changes from bug fixes. And I want any kind of source reformatting as a
> single commit, not spread out over a long period of time, as that makes
> it harder down the road to track actual logic changes.
>
> Finally, I would like to see a discussion of any change that modifies
> the existing APIs. These modules are very old, and sometimes have rather
> bad interfaces, but they are used by lots of scripts and have been
> documented in books and articles. I don’t want to break any of this. So
> if in doubt, please discuss first on [email protected].
>

That's fine. I'll keep this mail as a reference. Maybe we should add this as
a wiki page...

Cheers,
Olivier.