Re: BSD fixes

On 9/25/07, Michael G Schwern <[email protected]> wrote:
> Rafael Garcia-Suarez wrote:
> > I just committed change 31968 to ExtUtils::MM_Unix to add dragonfly to
> > the list of BSD-like OSes. See
> > http://public.activestate.com/cgi-bin/perlbrowse/p/31968
> >
> > But while doing so, I noticed that the statement was buggy anyway, so I
> > fixed that too:
> > http://public.activestate.com/cgi-bin/perlbrowse/p/31969
>
> What was buggy about it?

     $Is_SunOS   = $Is_SunOS4 || $Is_Solaris;
-    $Is_BSD     = $^O =~ /^(?:free|net|open)bsd$/ or
-                  $^O eq 'bsdos' or $^O eq 'interix' or $^O eq 'dragonfly';
+    $Is_BSD     = $^O =~ /^(?:(?:free|net|open)bsd|bsdos|interix|dragonfly)$/;

The former would never set $Is_BSD for 'bsdos', 'interix' and
'dragonfly' but only evaluate " $^O eq 'foo' " in void context.