Re: Remove nicetext() (was Re: [ANNOUNCE] ExtUtils::MakeMaker 6.38)

On Nov 30, 2007 6:39 PM, Michael G Schwern <[email protected]> wrote:
> Craig A. Berry wrote:
> > Looks like this has been this way a long time but never tested until
> > now.  Here's the debugger view of the smoking gun:
> >
> > ExtUtils::MM_VMS::nicetext(/perl_root/lib/ExtUtils/MM_VMS.pm:1588):
> > 1588:       $text =~ s/([^\s:])(:+\s)/$1 $2/gs;
> >
> > which is called from here:
> >
> > ExtUtils::MakeMaker::new(/perl_root/lib/ExtUtils/MakeMaker.pm:638):
> > 638:                push @{$self->{RESULT}},
> > $self->nicetext($self->$method( %a ));

> Do we need that crutch any more?  Most of the make targets already have that
> space, VMS isn't the only picky one about it, and I've just fixed the rest.
> I guess it might help if anyone overrides some methods with their own custom
> targets and fail to add the space, but it seems such a dubious hack.
>
> Let's try removing it and see what happens.

OK by me.

> Try the attached tarball, please.

All tests pass against blead.  There was one minor nit I forgot to
mention before; it doesn't cause any tests to fail, but if the
following warning is anything to be concerned about, let me know.

t/fixin.................
Use of uninitialized value $ExtUtils::MM_Unix::Config{"sharpbang"} in
pattern match (m//) at /D0/CRAIG/EUMM/blib/lib/ExtUtils/MM_Unix.pm
line 1078.