Re: ANNOUNCE ExtUtils::MakeMaker 6.47_02

[email protected] (Martin Becker)
Newsgroups perl.perl5.porters,perl.vmsperl,perl.makemaker
Message-ID <[email protected]>
On Thu, Oct 16, 2008 at 04:18:45PM -0700, Michael G Schwern wrote:
> http://schwern.org/src/ExtUtils-MakeMaker-6.47_02.tar.gz
> 
> Cutting a new release to fix some VMS issues on the new MIN_PERL_VERSION tests.
> 
> 
> 6.47_02  Thu Oct 16 16:14:20 PDT 2008
>     Test Fixes
>     * MIN_PERL_VERSION test had some goofs on VMS. [thanks Craig Berry]

Now the test has some goofs due to the changed semantics of
slurp ("die" replacing "return undef").  To fix that, add this patch.

-Martin
EUMM-6.47_02-fixfix.patch (text/plain, 1.2 KB)
diff -ru ExtUtils-MakeMaker-6.47_02.orig/Changes ExtUtils-MakeMaker-6.47_02/Changes
--- ExtUtils-MakeMaker-6.47_02.orig/Changes	Fri Oct 17 01:14:26 2008
+++ ExtUtils-MakeMaker-6.47_02/Changes	Fri Oct 17 21:14:33 2008
@@ -0,0 +1,4 @@
+6.47_??
+    Test Fixes
+    * MIN_PERL_VERSION test adapted to new slurp() semantics.
+
diff -ru ExtUtils-MakeMaker-6.47_02.orig/t/min_perl_version.t ExtUtils-MakeMaker-6.47_02/t/min_perl_version.t
--- ExtUtils-MakeMaker-6.47_02.orig/t/min_perl_version.t	Fri Oct 17 01:13:30 2008
+++ ExtUtils-MakeMaker-6.47_02/t/min_perl_version.t	Fri Oct 17 21:11:46 2008
@@ -173,7 +173,7 @@
 
     cmp_ok( $?, '==', 0,    'Make ppd exiting normally' ) || diag(@make_out);
 
-    my $ppd_html = slurp($ppd_file);
+    my $ppd_html = eval { slurp($ppd_file) };
     ok( defined($ppd_html), '  .ppd file present' );
 
     like( $ppd_html, qr{^\s*<PERLCORE VERSION="5,005,0,0" />}m,
@@ -191,7 +191,7 @@
     END { rmtree $distdir }
 
     cmp_ok( $?, '==', 0, 'Make metafile exiting normally' ) || diag(@make_out);
-    my $meta = slurp($meta_yml);
+    my $meta = eval { slurp($meta_yml) };
     ok( defined($meta),  '  META.yml present' );
 
     like( $meta, qr{\nrequires:[^\S\n]*\n\s+perl:\s+5\.005\n\s+strict:\s+0\n},
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.