Re: [PATCH] Haiku Port

[email protected] ("H.Merijn Brand")
Newsgroups perl.perl5.porters,perl.makemaker
Message-ID <[email protected]>
On Wed, 29 Oct 2008 03:09:06 -0700, Michael G Schwern
<[email protected]> wrote:

> Haiku is BeOS.
> It should use MM_BeOS.
> Delete the copy.
> 
> Less poetically, MM_Haiku appears to be just a copy of MM_BeOS.  Doesn't seem
> to be any benefit from a split, so just alter MM.pm so Haiku is recognized as
> a BeOS flavor.
> 
> --- a/lib/ExtUtils/MM.pm
> +++ b/lib/ExtUtils/MM.pm
> @@ -58,7 +58,7 @@ if( $^O eq 'MSWin32' ) {
>  $Is{UWIN}   = $^O =~ /^uwin(-nt)?$/;
>  $Is{Cygwin} = $^O eq 'cygwin';
>  $Is{NW5}    = $Config{osname} eq 'NetWare';  # intentional
> -$Is{BeOS}   = $^O =~ /beos/i;    # XXX should this be that loose?
> +$Is{BeOS}   = $^O =~ /beos/i or $^O eq 'haiku';

Hmm, I smell precedence error

$ perl -MO=Deparse -e'$a = $^O eq "x" or $^O eq "y"'
$^O eq 'y' unless $a = $^O eq 'x';

+$Is{BeOS}   = $^O =~ /beos/i || $^O eq 'haiku';

$ perl -MO=Deparse -e'$a = $^O eq "x" || $^O eq "y"'
$a = $^O eq 'x' || $^O eq 'y';

>  $Is{DOS}    = $^O eq 'dos';
>  if( $Is{NW5} ) {
>      $^O = 'NetWare';

-- 
H.Merijn Brand          Amsterdam Perl Mongers  http://amsterdam.pm.org/
using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,
11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin.
http://mirrors.develooper.com/hpux/           http://www.test-smoke.org/
http://qa.perl.org      http://www.goldmark.org/jeff/stupid-disclaimers/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.