Re: [ANNOUNCE] ExtUtils::MakeMaker 6.49_01

On Thu, Feb 19, 2009 at 05:15:03PM -0800, Michael G Schwern wrote:
> This release is mostly to fix the test failures due to changes in
> ExtUtils::Install 1.51's output format.
> http://schwern.org/src/ExtUtils-MakeMaker-6.49_01.tar.gz
> 
> 
> 6.49_01  Thu Feb 19 17:06:36 PST 2009
>     New OS Support
>     * Recognize "Haiku", a resurrection of BeOS.
> 
>     New Features
>     - META.yml now includes ExtUtils::MakeMaker in build_requires by
>       default.
> 
>     Test Fixes
>     - ExtUtils::Install 1.51 changed its output breaking some tests that
>       were looking for /^Writing/ [rt.cpan.org 42927]
> 
>     Bug Fixes
>     - Upgrade bundled modules:  ExtUtils::Install 1.52, ExtUtils::Command
>       1.16, ExtUtils::Manifest 1.56.
> 
>     Other
>     - The MakeMaker repository moved slightly.  Changed the metadata to
>       reflect this.  [rt.cpan.org 41571]
> 
> 
> 6.48  Mon Oct 20 11:18:13 PDT 2008
>     Test Fixes
>     * Protect against stray environment variables effecting the tests.
>       [rt.cpan.org 14930]

Applied to blead as 1487aac67a72b9f87b24113f65b4d878401bee33

I then re-applied the changes from
http://rt.perl.org/rt3/Public/Bug/Display.html?id=61492
to blead as 2f30d0d0af5b459d5c0f4734d92d4b55e9dcc9b7 as it seemed to be a fix
for a class of build failure:


diff --git a/lib/ExtUtils/MM_Win32.pm b/lib/ExtUtils/MM_Win32.pm
index 9246ca7..c0078a4 100644
--- a/lib/ExtUtils/MM_Win32.pm
+++ b/lib/ExtUtils/MM_Win32.pm
@@ -27,7 +27,7 @@ use ExtUtils::MakeMaker qw( neatvalue );
 require ExtUtils::MM_Any;
 require ExtUtils::MM_Unix;
 our @ISA = qw( ExtUtils::MM_Any ExtUtils::MM_Unix );
-our $VERSION = '6.49_01';
+our $VERSION = '6.49_02';
 
 $ENV{EMXSHELL} = 'sh'; # to run `commands`
 
@@ -338,13 +338,10 @@ $(INST_DYNAMIC): $(OBJECT) $(MYEXTLIB) $(BOOTSTRAP) $(INST_ARCHAUTODIR)$(DFSEP).
        q{	$(LD) -out:$@ $(LDDLFLAGS) }.$ldfrom.q{ $(OTHERLDFLAGS) }
       .q{$(MYEXTLIB) $(PERL_ARCHIVE) $(LDLOADLIBS) -def:$(EXPORT_LIST)});
 
-      # VS2005 (aka VC 8) or higher, but not for 64-bit compiler from Platform SDK
-      if ($Config{ivsize} == 4 && $Config{cc} eq 'cl' and $Config{ccversion} =~ /^(\d+)/ and $1 >= 14) 
-    {
-        push(@m,
-          q{
-	mt -nologo -manifest [email protected] -outputresource:$@;2 && del [email protected]});
-      }
+      # Embed the manifest file if it exists
+      push(@m, q{
+	if exist [email protected] mt -nologo -manifest [email protected] -outputresource:$@;2
+	if exist [email protected] del [email protected]});
     }
     push @m, '
 	$(CHMOD) $(PERM_RWX) $@



Bad us for not sending this on to you already.

I *didn't* re-apply the part of 4954abf77fcbac122d63699b1b3921b4d44d4570 to
blead:

diff --git a/lib/ExtUtils/MM_Any.pm b/lib/ExtUtils/MM_Any.pm
index 5e4bd69..2cee73f 100644
--- a/lib/ExtUtils/MM_Any.pm
+++ b/lib/ExtUtils/MM_Any.pm
@@ -1,7 +1,7 @@
 package ExtUtils::MM_Any;
 
 use strict;
-our $VERSION = '6.48';
+our $VERSION = '6.48_01';
 
 use Carp;
 use File::Spec;
@@ -354,7 +354,7 @@ to do some normalization on the information from %Config or the user.
 sub make {
     my $self = shift;
 
-    my $make = lc $self->{MAKE};
+    my $make = lc($self->{MAKE}|| '');
 
     # Truncate anything like foomake6 to just foomake.
     $make =~ s/^(\w+make).*/$1/;


as I think it was this part:

    This also silences an odd warning from MM_Any.pm that comes up once in a while, which I believe is to do with a deeper core failure as it occurs in code utterly unrelated to these changes.


and warnings aren't build failures.

The docs still say:

    Send patches and ideas to C<[email protected]>.


should I be raising RT tickets for these instead?

Nicholas Clark