[svn:modperl-modules] rev 152 - Apache-Scoreboard-2.0/trunk/lib/Apache

Author: stas
Date: Sat Feb 26 15:34:07 2005
New Revision: 152

Modified:
   Apache-Scoreboard-2.0/trunk/lib/Apache/Scoreboard.pm
Log:
handle errors better


Modified: Apache-Scoreboard-2.0/trunk/lib/Apache/Scoreboard.pm
==============================================================================
--- Apache-Scoreboard-2.0/trunk/lib/Apache/Scoreboard.pm	(original)
+++ Apache-Scoreboard-2.0/trunk/lib/Apache/Scoreboard.pm	Sat Feb 26 15:34:07 2005
@@ -5,6 +5,8 @@
 use strict;
 use warnings FATAL => 'all';
 
+use Carp;
+
 BEGIN {
     require mod_perl;
     die "This module was built against mod_perl 2.0 ",
@@ -22,7 +24,6 @@
     require Apache::DummyScoreboard;
 }
 
-
 use constant DEBUG => 0;
 
 my $ua;
@@ -39,10 +40,8 @@
 
     my $request = HTTP::Request->new('GET', $url);
     my $response = $ua->request($request);
-    unless ($response->is_success) {
-	warn "request failed: ", $response->status_line if DEBUG;
-	return undef;
-    }
+    die "failed to execute: 'GET $url', response: ",
+        $response->status_line unless $response->is_success;
 
     # XXX: fixme
 #    my $type = $response->header('Content-type');
@@ -66,6 +65,7 @@
 
 sub store {
     my($self, $frozen_image, $file) = @_;
+    croak "undefined image passed" unless $frozen_image;
     open my $fh, ">$file" or die "open $file: $!";
     print $fh $frozen_image;
     close $fh;