Re: Filter-1.60

[email protected] (Reini Urban) Sat, 15 Jan 2022 21:27:01 +0100
Newsgroups perl.module-authors
Message-ID <CAHiT=DFWqdEe1ejDYK8xc33escg-+dC-CDDnVSLEMe8Z1rS3Sw@mail.gmail.com>
--0000000000008e7c9305d5a4be69
Content-Type: text/plain; charset="UTF-8"

Interesting. This fell off my radar. Maybe it would have been better to
file an official ticket. Emails can get lost.

David Christensen <[email protected]> schrieb am Sa., 15. Jan.
2022, 20:55:

> module-authors:
>
> I submitted a patch for Filter::Cpp about three months ago to Reini
> Urban and Paul Marquess, but never heard back from either of them.
>
>
> I seem to recall that I later tested the changes on macOS and FreeBSD,
> and they failed.
>
>
> Suggestions?
>
>
> David
>
>
>
> -------- Forwarded Message --------
> Subject: Filter-1.60
> Date: Wed, 20 Oct 2021 21:47:14 -0700
> From: David Christensen <[email protected]>
> To: [email protected]
> CC: [email protected]
>
> Reini:
>
> Thank you for your work on Filter.  :-)
>
>
> Attached please find a tarball (Filter-1.60-dpchrist-20211016.tar.gz)
> with some changes I made to Filter::cpp to help it work better with Perl
> code:
>
> 1.  Added a pre-filter to escape octothorps ('#') not involved with C
> preprocessor control-lines.
>
> 2.  Added a post-filter to unescape octothorps.
>
> 3.  Added an options hash %opt with default values that can be
> overridden via Filter::cpp import() arguments.
>
> 4.  Reworked the cpp and sh invocations to use %opt.
>
> 5.  Added a debugging function, _d(), that is controlled by the
> DEBUG_FILTER__CPP environment variable and writes debug messages to a
> file named after the running script: "$0.debug".
>
> 6.  Reworked cpp.t to dump variables on test failure, and to keep
> generated files on test failure or when debugging is enabled.
>
> 7.  Added generated files to Makefile.PL 'clean' target.
>
>
> At this point, all of the test suite except t/z_manifest.t (skipped)
> passes on Debian GNU/Linux 9, and Filter::cpp works correctly with a
> simple example module (MyLib-0.01-dpchrist-20211016.tar.gz, attached).
>
>
> I would like to contribute my changes to Filter, if you find them
> agreeable.  I am willing to learn and help do the work, but am
> unfamiliar with the process (CPAN, Git, and/or GitHub).
>
>
> Please advise.
>
>
> David
>
>

--0000000000008e7c9305d5a4be69
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">Interesting. This fell off my radar. Maybe it would have =
been better to file an official ticket. Emails can get lost.</div><br><div =
class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">David Christens=
en &lt;<a href=3D"mailto:[email protected]">[email protected]=
om</a>&gt; schrieb am Sa., 15. Jan. 2022, 20:55:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex">module-authors:<br>
<br>
I submitted a patch for Filter::Cpp about three months ago to Reini <br>
Urban and Paul Marquess, but never heard back from either of them.<br>
<br>
<br>
I seem to recall that I later tested the changes on macOS and FreeBSD, <br>
and they failed.<br>
<br>
<br>
Suggestions?<br>
<br>
<br>
David<br>
<br>
<br>
<br>
-------- Forwarded Message --------<br>
Subject: Filter-1.60<br>
Date: Wed, 20 Oct 2021 21:47:14 -0700<br>
From: David Christensen &lt;<a href=3D"mailto:[email protected]" ta=
rget=3D"_blank" rel=3D"noreferrer">[email protected]</a>&gt;<br>
To: <a href=3D"mailto:[email protected]" target=3D"_blank" rel=3D"noreferrer"=
>[email protected]</a><br>
CC: <a href=3D"mailto:[email protected]" target=3D"_blank" rel=3D"noreferrer">p=
[email protected]</a><br>
<br>
Reini:<br>
<br>
Thank you for your work on Filter.=C2=A0 :-)<br>
<br>
<br>
Attached please find a tarball (Filter-1.60-dpchrist-20211016.tar.gz) <br>
with some changes I made to Filter::cpp to help it work better with Perl <b=
r>
code:<br>
<br>
1.=C2=A0 Added a pre-filter to escape octothorps (&#39;#&#39;) not involved=
 with C <br>
preprocessor control-lines.<br>
<br>
2.=C2=A0 Added a post-filter to unescape octothorps.<br>
<br>
3.=C2=A0 Added an options hash %opt with default values that can be <br>
overridden via Filter::cpp import() arguments.<br>
<br>
4.=C2=A0 Reworked the cpp and sh invocations to use %opt.<br>
<br>
5.=C2=A0 Added a debugging function, _d(), that is controlled by the <br>
DEBUG_FILTER__CPP environment variable and writes debug messages to a <br>
file named after the running script: &quot;$0.debug&quot;.<br>
<br>
6.=C2=A0 Reworked cpp.t to dump variables on test failure, and to keep <br>
generated files on test failure or when debugging is enabled.<br>
<br>
7.=C2=A0 Added generated files to Makefile.PL &#39;clean&#39; target.<br>
<br>
<br>
At this point, all of the test suite except t/z_manifest.t (skipped) <br>
passes on Debian GNU/Linux 9, and Filter::cpp works correctly with a <br>
simple example module (MyLib-0.01-dpchrist-20211016.tar.gz, attached).<br>
<br>
<br>
I would like to contribute my changes to Filter, if you find them <br>
agreeable.=C2=A0 I am willing to learn and help do the work, but am <br>
unfamiliar with the process (CPAN, Git, and/or GitHub).<br>
<br>
<br>
Please advise.<br>
<br>
<br>
David<br>
<br>
</blockquote></div>

--0000000000008e7c9305d5a4be69--