Re: actually using the distgen chdir enhancements

[email protected] (Eric Wilhelm)
Newsgroups perl.module.build
Message-ID <[email protected]>
# from Eric Wilhelm
# on Wednesday 09 July 2008 00:29:

>I'm not seeing how this is required (since -d $tmp should be false if
>you're in the directory)

Oh.  That was an absolute path.  It was being deleted while we were in 
it.

Most systems have no trouble deleting the current directory, but it 
would be nice to generally avoid that.

All of the tests were consistently performing their own
'chdir($dist->dirname) or die "blah blah blah"' and then later calling 
$dist->remove without having returned to the original directory.

I added an automagic $dist->chdir_original() to the remove() method and 
changed all of the tests to use $dist->chdir_in().

David, please try r11502 and let me know if this passes on your 5.10.

Thanks,
Eric
-- 
perl -e 'srand; print join(" ",sort({rand() < 0.5}
  qw(sometimes it is important to be consistent)));'
---------------------------------------------------
    http://scratchcomputing.com
---------------------------------------------------
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.