Re: ken broke 5.6.2 in may 2008 -- t/ext.t t/xs.t
[email protected] ("David E. Wheeler")
| Newsgroups | perl.module.build |
|---|---|
| Message-ID | <[email protected]> |
On Sep 13, 2008, at 19:04, Eric Wilhelm wrote: >> $ perlv562 Build.PL >> >> $ ./Build test --test-files t/ext.t t/xs.t >> t/ext......1/187 >> # Failed test (t/ext.t at line 148) >> # Structures begin differing at: >> # $got->[0] = Does not exist >> # $expected->[0] = 'one >> # two' > > If nobody wants to fix it, I'll happily bump the required perl > version, > but I'm just the guy in shipping. This appears to be a difference between the implementation of Text::ParseWords::shellwords() in 5.6 vs in 5.10 (and presumably 5.8). I think we should just skip that particular test on 5.6. Patch attached. Best, David
shellwords_on_5.6.patch
(application/octet-stream, 439 B)
Index: t/ext.t
===================================================================
--- t/ext.t (revision 11789)
+++ t/ext.t (working copy)
@@ -145,5 +145,8 @@
is( 0 + grep( !defined(), @result ), # all defined
0,
"'$string' result all defined" );
- is_deeply(\@result, $expected);
+ SKIP: {
+ skip 'Text::ParseWords::shellwords() is finicky in 5.6', 1 if $] < 5.008;
+ is_deeply(\@result, $expected);
+ };
}