Re: Indentation (was Re: invalid installdirs values)

[email protected] (Michael G Schwern)
Newsgroups perl.module.build
Message-ID <[email protected]>
David E. Wheeler wrote:
> On Sep 27, 2008, at 14:11, Michael G Schwern wrote:
> 
>> Try using diff -b.  It filters out whitespace changes making it easier
>> to see
>> the significant changes.
> 
> I used `svn diff -x '-ub'. Attached.

You can set SVKDIFF='diff -bu' to do that all the time.  I've sometimes even
thrown in -w, -B and -E.


>> At the risk of starting a flamewar, can we reindent the whole thing at 4
>> characters?  The 2 char indent means we're constantly going to have to
>> reindent submissions.
> 
> +1 YES, PLEASE! This is the indentation I always use. Also, no tabs
> (there are lots in the source).

FWIW I ran perltidy over the source and the tests passed.  This is the
perltidy from Test::More which would be a good place to start.

http://test-more.googlecode.com/svn/trunk/.perltidyrc

Once the code is tidy one can play the "tidy with our own personal settings,
edit, tidy with project settings, commit" game if the project style is that
bothersome.


-- 
If at first you don't succeed--you fail.
	-- "Portal" demo
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.