A couple of patches from Debian
[email protected] (Alessandro Ghedini)
| Newsgroups | perl.moose |
|---|---|
| Message-ID | <[email protected]> |
Hi all,
I am one of the members of the Debian Perl Group [0] (our role is basically
maintaining Perl modules, including Moose, in Debian).
As part of this work we are applying a couple of small patches to the Moose
package which I think may be of some interest to you (I've attached them
to this mail, since I don't have commit rights for the Moose git
repository).
* Work around a numification problem on ia64
This basically fixes a test failure on the ia64 (Itanium) architecture.
This has been already reported as RT#59478 [1] and perl #77456 [2], and
seems to be already fixed in perl itself (commit a42d02426c, from v5.13.8).
* Fix small POD errors
This just fixes a couple of POD errors found by pod2man.
Both the patches are quite trivial (1-2 lines changed), apply to the
'master' branch (as per Moose::Manual::Contributing for small fixes) and
are generated using git-format-patch, so that they can be easily merged
using git-am.
Cheers
[0] http://wiki.debian.org/Teams/DebianPerlGroup
[1] https://rt.cpan.org/Public/Bug/Display.html?id=59478
[2] https://rt.perl.org/rt3/Public/Bug/Display.html?id=77456
--
perl -E'$_=q;$/= @{[@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'
0001-Work-around-a-numification-problem-on-ia64.patch
(text/x-diff, 1.1 KB)
From f641f3c927f1572892f5bcace19a308eb6839f2e Mon Sep 17 00:00:00 2001 From: Alessandro Ghedini <[email protected]> Date: Wed, 7 Sep 2011 11:44:06 +0200 Subject: [PATCH] Work around a numification problem on ia64 As seen in <https://rt.cpan.org/Public/Bug/Display.html?id=59478>, the numeric comparison seems to trigger a bug in perl 5.10.1 on the ia64 architecture. Explicitly numifying before comparing seems to work around this. Patch contributed by Niko Tyni. --- lib/Moose/Meta/TypeConstraint.pm | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/Moose/Meta/TypeConstraint.pm b/lib/Moose/Meta/TypeConstraint.pm index 2b56617..e1349a5 100644 --- a/lib/Moose/Meta/TypeConstraint.pm +++ b/lib/Moose/Meta/TypeConstraint.pm @@ -255,7 +255,7 @@ sub equals { my $other = Moose::Util::TypeConstraints::find_type_constraint($type_or_name) or return; - return 1 if $self == $other; + return 1 if (0+$self == 0+$other); if ( $self->has_hand_optimized_type_constraint and $other->has_hand_optimized_type_constraint ) { return 1 if $self->hand_optimized_type_constraint == $other->hand_optimized_type_constraint; -- 1.7.5.4
0002-Fix-small-POD-errors.patch
(text/x-diff, 1.3 KB)
From 96188f70ca89a5d55c015db17515162de85da15a Mon Sep 17 00:00:00 2001 From: Alessandro Ghedini <[email protected]> Date: Wed, 7 Sep 2011 11:45:57 +0200 Subject: [PATCH] Fix small POD errors Fix a couple of POD errors found by pod2man. Patch contributed by Ansgar Burchardt and me. --- lib/Moose/Manual/Delta.pod | 2 ++ lib/Moose/Meta/Attribute/Native/Trait/Array.pm | 2 +- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lib/Moose/Manual/Delta.pod b/lib/Moose/Manual/Delta.pod index 77acf92..7c1c2ea 100644 --- a/lib/Moose/Manual/Delta.pod +++ b/lib/Moose/Manual/Delta.pod @@ -62,6 +62,8 @@ L<Moose::Util::TypeConstraints>. Use C<inline_as> instead. This will start warning in the 2.0300 release. +=back + =head1 2.0002 =over 4 diff --git a/lib/Moose/Meta/Attribute/Native/Trait/Array.pm b/lib/Moose/Meta/Attribute/Native/Trait/Array.pm index 872e6a6..d3c7704 100644 --- a/lib/Moose/Meta/Attribute/Native/Trait/Array.pm +++ b/lib/Moose/Meta/Attribute/Native/Trait/Array.pm @@ -300,7 +300,7 @@ in the array. This method accepts one or two arguments. -=item B<shallow_clone> +=item * B<shallow_clone> This method returns a shallow clone of the array reference. The return value is a reference to a new array with the same elements. It is I<shallow> -- 1.7.5.4