Re: [PATCH] testsuite quick fixes

--huq684BweRXVnRxX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Aug 05, 2002 at 12:00:55PM -0400, Andy Dougherty wrote:
> On Sun, 4 Aug 2002, Richard Clamp wrote:
> > On Sat, Aug 03, 2002 at 04:01:58PM -0400, Garth Sainio wrote:
> > > If you pass the -fwritable-strings to gcc that seems to solve the
> > 
> > Excellent news.  I think I was kicking an inverse solution by using
> > strdup to make a locally writable copy.  I didn't realise I could have
> > the compiler do it for me, but now I do I much refer your solution
> > since it's a much smaller change.
> 
> Without looking at the code in question, I suspect that the strdup() fix
> is the right one.  Not everyone has gcc.

But do things !gcc have string constants as being unwritable?  I'm not
quibbling, I'll make the patch anyway, it's just my curiosity about
other ccs showing itself.

> If you take a modern metaconfig and just point it at perl1, it'll
> automatically generate a modern Configure that will understand hints.

Wow, yes.  That was nifty.  I've nabbed all the hints from 5.8.0 and
added them to my repository.

> None of this would add to perl1 "bloat" -- just ease the Configure and
> build process.  Some changes to perl1 source would be required to use the
> "new" symbol names/conventions introduced to Configure over the past
> decade or so, but it'd probably be worth it.

The only one that I encountered was HAS_CRYPT changing from CRYPT, it
did suggest that I should update some symbols (see attached) but I
didn't yet.

-- 
Richard Clamp <[email protected]>

--huq684BweRXVnRxX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=Obsolete


              File                 |      Old symbol      |      New symbol
-----------------------------------+----------------------+---------------------
arg.c                              | CRYPT                | HAS_CRYPT
arg.c                              | RENAME               | HAS_RENAME
arg.c                              | STATBLOCKS           | USE_STAT_BLOCKS
arg.c                              | STDSTDIO             | USE_STDIO_PTR
arg.c                              | STRUCTCOPY           | USE_STRUCT_COPY
arg.h                              | CRYPT                | HAS_CRYPT
arg.h                              | RENAME               | HAS_RENAME
arg.h                              | SELECT               | HAS_SELECT
arg.h                              | STAT                 | HAS_STAT
arg.h                              | SYSTEM               | HAS_SYSTEM
arg.h                              | TIMES                | HAS_TIMES
perl.h                             | STDSTDIO             | USE_STDIO_PTR
perl.h                             | TMINSYS              | TM_IN_SYS
perl.y                             | SELECT               | HAS_SELECT
perl.y                             | STAT                 | HAS_STAT
perly.c                            | P                    | _
perly.c                            | SELECT               | HAS_SELECT
perly.c                            | STAT                 | HAS_STAT
str.c                              | STDSTDIO             | USE_STDIO_PTR
x2p/a2py.c                         | P                    | _
x2p/str.c                          | STDSTDIO             | USE_STDIO_PTR

--huq684BweRXVnRxX--