Re: Call back units

On Sat 01 Nov 2003 15:11, "H.Merijn Brand" <[email protected]> wrote:
> As announced in my plans somewhere back in september 2002, I finally foun=
d
> time to check and change.
>=20
> The plan was to make the call-back's safe and call them allways, even if =
the
> option for which the call-back was cretead is unset.
>=20
> To do so, two criteria should be met:
>=20
> 1. All currently created call-back should have code to check that they wi=
ll
>    only do what they are supposed to do when the option *is* set.
> 2. Configure should allways call them, but still be safe in how to deal w=
ith
>    what it currently does.
>=20
> Both are pure for backward compatibility, and shouldn't alter the current
> behaviour, but open up for expansions in the call-back units to do things=
 in
> case the option is *not* set.
>=20
> I was amazed to find that point 1 is already met. This means that the set=
ting
> of the variable currently is done twice, once in Configure, and when it's=
 set
> end the cbu is called, it's checked again. I expected to have a lot of wo=
rk in
> this area, but I have no work here at all :)
>=20
> Below are the proposed patches.
>=20
> a. The patch to hints/README.hints, explaining that the cbu's should take=
 care
>    of item 1.
> b. The complete patch to Configure, This will have to be broken up to the
>    metaunits
> c. A small patch to solaris_2.sh, which I think simplifies reading

a) and b) as

Change 21712 by merijn@merijn-l1 on 2003/11/13 09:22:21

        Enable hints to create call-back units that can act when
        a specific variable is *not* set (like -Uuselargefiles)

Affected files ...

=2E.. //depot/perl/Configure#551 edit
=2E.. //depot/perl/hints/README.hints#13 edit

c) as

Change 21713 by merijn@merijn-l1 on 2003/11/13 09:25:15

        Simplified the reading

Affected files ...

=2E.. //depot/perl/hints/solaris_2.sh#89 edit


--=20
H.Merijn Brand        Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using perl-5.6.1, 5.8.0, & 5.9.x, and 806 on  HP-UX 10.20 & 11.00, 11i,
   AIX 4.3, SuSE 8.2, and Win2k.           http://www.cmve.net/~merijn/
http://archives.develooper.com/[email protected]/   [email protected]
send smoke reports to: [email protected], QA: http://qa.perl.org