[Perl/perl5] b9d062: threads::shared: remove problematic err.t test
[email protected] (David Mitchell via perl5-changes) Mon, 25 May 2026 05:38:49 -0700
| Newsgroups | perl.perl5.changes |
|---|---|
| Message-ID | <Perl/perl5/push/refs/heads/davem/thread_races/[email protected]> |
Branch: refs/heads/davem/thread_races
Home: https://github.com/Perl/perl5
Commit: b9d06266741dfc15d0d8706f412be62f270b82b1
https://github.com/Perl/perl5/commit/b9d06266741dfc15d0d8706f412be62f270b82b1
Author: David Mitchell <[email protected]>
Date: 2026-05-25 (Mon, 25 May 2026)
Changed paths:
M dist/threads-shared/t/err.t
Log Message:
-----------
threads::shared: remove problematic err.t test
This test checks that a warning is issued when two threads call
cond_wait() for the same condition var, but with different locks.
The problem is that shared.xs then calls the underlying OS's cond_wait()
functions with similarly bad values, triggering undefined behaviour. On
some platforms this caused pthreads_cond_wait() to return an error code,
triggering a panic and deadlock.
So just remove the test.
Commit: 4ecaf497a63c6785d84b62ed8d37965d5f5b90cd
https://github.com/Perl/perl5/commit/4ecaf497a63c6785d84b62ed8d37965d5f5b90cd
Author: David Mitchell <[email protected]>
Date: 2026-05-25 (Mon, 25 May 2026)
Changed paths:
M dist/threads/threads.xs
Log Message:
-----------
threads.xs: remove unneeded locking
After some refactoring, there was a vestigial piece of locking around
a PerlMemShared_malloc() call in S_ithread_create(). Remove it, since
its unnecessary now.
Compare: https://github.com/Perl/perl5/compare/19dbad971aa2...4ecaf497a63c
To unsubscribe from these emails, change your notification settings at https://github.com/Perl/perl5/settings/notifications