[Perl/perl5] db87aa: mkppport: fix build from path containing spaces

[email protected] (Lukas Mai via perl5-changes)
Newsgroups perl.perl5.changes
Message-ID <Perl/perl5/push/refs/heads/blead/[email protected]>
  Branch: refs/heads/blead
  Home:   https://github.com/Perl/perl5
  Commit: db87aab5f34e7f419719ea5fd14b82ee1d2c5768
      https://github.com/Perl/perl5/commit/db87aab5f34e7f419719ea5fd14b82ee1d2c5768
  Author: Lukas Mai <[email protected]>
  Date:   2026-08-10 (Mon, 10 Aug 2026)

  Changed paths:
    M mkppport

  Log Message:
  -----------
  mkppport: fix build from path containing spaces

Since commit 88e241815c36, which_perl() adds quotes to its return value
if it contains spaces. When we try to do the same thing, the doubled-up
quotes end up canceling each other out:

    ./miniperl -Ilib mkppport
    running ""/tmp/somewhere 1/perl-5.44.0/miniperl"" -I../../lib PPPort_pm.PL
    sh: 1: /tmp/somewhere: not found

Just use which_perl()'s return value as is.

See #24670.


  Commit: c8b44e7ff48eab46f84ebddf21b46f35178baf50
      https://github.com/Perl/perl5/commit/c8b44e7ff48eab46f84ebddf21b46f35178baf50
  Author: Lukas Mai <[email protected]>
  Date:   2026-08-10 (Mon, 10 Aug 2026)

  Changed paths:
    M Makefile.SH

  Log Message:
  -----------
  Makefile.SH: quote pwd for shell use

This should fix a few more "build path contains spaces" issues.

See #24670.


  Commit: 06eae6be4f259a1b168dbcd1ef3c45fe133a0696
      https://github.com/Perl/perl5/commit/06eae6be4f259a1b168dbcd1ef3c45fe133a0696
  Author: Lukas Mai <[email protected]>
  Date:   2026-08-10 (Mon, 10 Aug 2026)

  Changed paths:
    M t/base/term.t
    M t/io/pipe.t
    M t/test.pl

  Log Message:
  -----------
  quote perl executable name in more tests

This should fix a few more "build path contains spaces" issues.

See #24670.


  Commit: 7dd9556e013d0066dc3feabacd5c4727d6e145d9
      https://github.com/Perl/perl5/commit/7dd9556e013d0066dc3feabacd5c4727d6e145d9
  Author: Lukas Mai <[email protected]>
  Date:   2026-08-10 (Mon, 10 Aug 2026)

  Changed paths:
    M Porting/bench.pl
    M t/porting/authors.t
    M t/porting/bench.t
    M t/porting/bench_selftest.t
    M t/porting/checkcfgvar.t
    M t/porting/cmp_version.t
    M t/porting/cpphdrcheck.t
    M t/porting/perlfunc.t
    M t/porting/regen.t
    M t/porting/test_testlist.t

  Log Message:
  -----------
  make porting tests work with spaces in build path

See #24670.


  Commit: 9351cf9145b434ce0886a2f6539387be00b1ed83
      https://github.com/Perl/perl5/commit/9351cf9145b434ce0886a2f6539387be00b1ed83
  Author: Lukas Mai <[email protected]>
  Date:   2026-08-10 (Mon, 10 Aug 2026)

  Changed paths:
    M hints/catamount.sh
    M hints/cygwin.sh
    M hints/linux-android.sh

  Log Message:
  -----------
  hints files: quote pwd-related variables

Hopefully this is enough to make builds with spaces in the path work.


  Commit: 1639403d95d850c9cb609b7144e641c78e8fc5dc
      https://github.com/Perl/perl5/commit/1639403d95d850c9cb609b7144e641c78e8fc5dc
  Author: Lukas Mai <[email protected]>
  Date:   2026-08-10 (Mon, 10 Aug 2026)

  Changed paths:
    M t/lib/warnings/doio
    M t/lib/warnings/op

  Log Message:
  -----------
  warnings tests: handle spaces in path


  Commit: ac3d3bf165b1183cee17da2bd7e51d79ab0ee606
      https://github.com/Perl/perl5/commit/ac3d3bf165b1183cee17da2bd7e51d79ab0ee606
  Author: Lukas Mai <[email protected]>
  Date:   2026-08-10 (Mon, 10 Aug 2026)

  Changed paths:
    M t/test.pl

  Log Message:
  -----------
  t/test.pl: don't overwrite args in place


  Commit: 5355a72c746fa5146541d790aece53b22737afee
      https://github.com/Perl/perl5/commit/5355a72c746fa5146541d790aece53b22737afee
  Author: Lukas Mai <[email protected]>
  Date:   2026-08-10 (Mon, 10 Aug 2026)

  Changed paths:
    M lib/h2xs.t
    M t/io/dup.t
    M t/io/open.t
    M t/io/openpid.t
    M t/io/through.t
    M t/op/alarm.t
    M t/op/die_exit.t
    M t/op/exec.t
    M t/op/fork.t
    M t/op/lex_assign.t
    M t/op/magic.t
    M t/op/srand.t
    M t/run/cloexec.t
    M t/run/locale.t
    M t/run/script.t
    M t/run/switches.t
    M t/run/switcht.t
    M t/test.pl

  Log Message:
  -----------
  tests: make a bunch pass with spaces in path


Compare: https://github.com/Perl/perl5/compare/a24839425c75...5355a72c746f

To unsubscribe from these emails, change your notification settings at https://github.com/Perl/perl5/settings/notifications
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.