[Perl/perl5] e68ba5: regen/embed.pl: Sort list
[email protected] (Karl Williamson via perl5-changes)
| Newsgroups | perl.perl5.changes |
|---|---|
| Message-ID | <Perl/perl5/push/refs/heads/blead/[email protected]> |
Branch: refs/heads/blead
Home: https://github.com/Perl/perl5
Commit: e68ba51caef91da37266ad15bacf80d573143f16
https://github.com/Perl/perl5/commit/e68ba51caef91da37266ad15bacf80d573143f16
Author: Karl Williamson <[email protected]>
Date: 2026-08-17 (Mon, 17 Aug 2026)
Changed paths:
M regen/embed.pl
Log Message:
-----------
regen/embed.pl: Sort list
This list had gotten out of order
Commit: 35694276f3eb4e8b7b3ce4cb2e9fa8a5cf92a03a
https://github.com/Perl/perl5/commit/35694276f3eb4e8b7b3ce4cb2e9fa8a5cf92a03a
Author: Karl Williamson <[email protected]>
Date: 2026-08-17 (Mon, 17 Aug 2026)
Changed paths:
M regcomp_internal.h
M regen/embed.pl
M t/porting/symbol_visibility.dat
Log Message:
-----------
Symbols in regcomp_internal.h are not generally visible
As its name implies, this header file is only for the use of the regular
expression pattern compilation subsystem. regen/embed.pl is not clever
enough to realize this, and was falsely concluding that the symbols in
it are visible everywhere.
The reason that these symbols aren't widely visible is that this header
is currently only #included by a few files, like regcomp.c. And
regen/embed.pl doesn't take into consideration that headers may not be
used globally. Most headers are in fact global, by virtue of being
included by perl.h.
This commit adds cpp conditional guards so as to not expand except when
compiled in the regex compilation subsystem. This both 1) alerts
regen/embed.pl to its limited use; and 2) actually limits its use,
defending against an inadvertent change that includes it from other
files.
Note that regcomp.c is copied to the 're' module under the name
're_comp.c'. Some modules on cpan pretend that they are that module, so
these symbols show up as being used in cpan. This commit should not
affect this.
Compare: https://github.com/Perl/perl5/compare/b789382b869a...35694276f3eb
To unsubscribe from these emails, change your notification settings at https://github.com/Perl/perl5/settings/notifications