Re: [perl #75520] PATCH: Fix uc() for Greek YPOGEGRAMMENI
[email protected] (karl williamson)
| Newsgroups | perl.perl5.porters |
|---|---|
| Message-ID | <[email protected]> |
Reini Urban wrote: > 2010/6/2 karl williamson <[email protected]>: >> # New Ticket Created by karl williamson >> # Please include the string: [perl #75520] >> # in the subject line of all future correspondence about this issue. >> # <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=75520 > >> >> >> Attached. > > I think you have a typo/thinko in > 0001-t-uni-case.pl-allow-extra-tests-of-different-form.patch > > -casetest("Upper", \%utf8::ToSpecUpper, sub { uc $_[0] }, > +casetest( 0, # extra tests already run > + "Upper", \%utf8::ToSpecUpper, > + sub { uc $_[0] }, > > => > > -casetest("Upper", \%utf8::ToSpecUpper, sub { uc $_[0] }, > +casetest( 1, # extra tests already run > + "Upper", \%utf8::ToSpecUpper, > + sub { uc $_[0] }, > I don't think so. I tested both patches and they both look right to me. The first one merely enables the ability to add tests, without actually adding any. The second patch actually changes that 0 to a 1 and adds the test. I'm doing what I thought was recommended to split patches into separable components, in case one part has to be backed out.