Re: [perl #75812] kill $1 broken in 5.12.1

On Wed, Jun 16, 2010 at 4:08 PM, Todd Rinaldo <[email protected]>wrote:

> # New Ticket Created by  Todd Rinaldo
> # Please include the string:  [perl #75812]
> # in the subject line of all future correspondence about this issue.
> # <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=75812 >
>
>
> We've discovered that this snippet will break in perl 5.12
>
> my $pid = "12345  ";
> if($pid =~ m/(\d+)/) {
>        kill 9, $1;
> }
>
> it dies with this message:
> Can't kill a non-numeric process ID at test.pl line 7.
>

The fix is simply the following x3, I think:

+SvGETMAGIC(*mark);
 if (!(SvIOK(*mark) || SvNOK(*mark) || looks_like_number(*mark)))
     Perl_croak(aTHX_ "Can't kill a non-numeric process ID");
-proc = SvIV(*mark);
+proc = SvIV_nomg(*mark);

Clean test:

'abc' =~ /(.*)/;  # Make sure PV has non-number.
my $x = $1;
$pid =~ /(.*)/;
kill TERM => $1;