Re: podlators 4.06 released
[email protected] (Russ Allbery) Sun, 20 Mar 2016 16:21:31 -0700
| Newsgroups | perl.pod-people,perl.perl5.porters |
|---|---|
| Organization | The Eyrie |
| Message-ID | <[email protected]> |
Dave Mitchell <[email protected]> writes: > But I don't think its necessary after all: the new() method in Pod::Man > is only called in three places during the build: > 1. Building cpan/podlators. > At this point Encode isn't built, and the warning is emitted > 2. Testing cpan/podlators/t/*/*.t > At this point Encode is built and there are no warnings. > 3. Installing perl and all its modules > It's called many times here, but again, at this point Encode is built so > there are no warnings > Only during (1) is the environment variable PERL_CORE set. > Unless there's a need for Encode to be present when padlators is made, > I propose that the code in Pod::Man::new() which warns if Encode isn't > present, only does so if !$ENV{PERL_CORE}. This is a great idea. Thanks! Now implemented, and will be in the next podlators release (probably later today). -- Russ Allbery ([email protected]) <http://www.eyrie.org/~eagle/>