[svn:ponie] r344 - trunk/src/pmc

[email protected] 25 Aug 2005 16:13:36 -0000
Newsgroups perl.ponie.changes
Message-ID <[email protected]>
Author: nicholas
Date: Thu Aug 25 09:13:36 2005
New Revision: 344

Modified:
   trunk/src/pmc/perl5cargo_cult.pmc
Log:
Merge change 25330:
Promote the warning about reference miscount in sv_replace to a panic.


Modified: trunk/src/pmc/perl5cargo_cult.pmc
==============================================================================
--- trunk/src/pmc/perl5cargo_cult.pmc	(original)
+++ trunk/src/pmc/perl5cargo_cult.pmc	Thu Aug 25 09:13:36 2005
@@ -660,8 +660,11 @@ pmclass Perl5cargo_cult dynpmc {
                 int type = SvTYPE(nsv);
 
                 SV_CHECK_THINKFIRST_COW_DROP(sv);
-                if (SvREFCNT(nsv) != 1 && ckWARN_d(WARN_INTERNAL))
-                    Perl_warner(aTHX_ packWARN(WARN_INTERNAL), "Reference miscount in sv_replace()");
+                if (SvREFCNT(nsv) != 1) {
+                    Perl_croak(aTHX_ "panic: reference miscount on nsv in "
+                               "sv_replace() (%" UVuf " != 1)",
+                               (UV) SvREFCNT(nsv));
+                }
                 if (SvMAGICAL(sv)) {
                     if (SvMAGICAL(nsv))
                         mg_free(nsv);