[PATCH] Fix illegal CFLAGS
[email protected] (Andrew Dougherty) Fri, 12 Mar 2004 16:58:55 -0500 (EST)
| Newsgroups | perl.ponie.dev |
|---|---|
| Message-ID | <[email protected]> |
While checking out ponie-2, I got stuck building parrot. The
following patch papers over the problem, but I wonder why
makefiles.pl is altering CFLAGS. Shouldn't that information
logically be in CFLAGS.in?
diff -r -u parrot/config/gen/makefiles.pl parrot-andy/config/gen/makefiles.pl
--- parrot/config/gen/makefiles.pl Mon Mar 8 19:00:04 2004
+++ parrot-andy/config/gen/makefiles.pl Fri Mar 12 16:43:12 2004
@@ -35,10 +35,13 @@
open(CFLAGS, ">> CFLAGS") or die "open >> CFLAGS: $!";
+ # Why is this here? I'd think this information belongs
+ # in the CFLAGS.in file. -- A.D. March 12, 2004
if (Configure::Data->get('cpuarch') =~ /sun4|sparc64/) {
+ # CFLAGS entries must be left-aligned.
print CFLAGS <<"EOF";
- jit_cpu.c -{-Wcast-align} # lots of noise!
- nci.c -{-Wstrict-prototypes} # lots of noise!
+jit_cpu.c -{-Wcast-align} # lots of noise!
+nci.c -{-Wstrict-prototypes} # lots of noise!
EOF
}
--
Andy Dougherty [email protected]