Re: 5.9.1 release now integrated into ponie
[email protected] (Nicholas Clark) Fri, 9 Apr 2004 23:31:04 +0100
| Newsgroups | perl.ponie.dev |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Apr 09, 2004 at 11:26:57PM +0100, Dave Mitchell wrote:
> On Fri, Apr 09, 2004 at 07:36:27PM +0100, Nicholas Clark wrote:
> > On Fri, Apr 09, 2004 at 01:51:02AM +0100, Nicholas Clark wrote:
> > For the moment I've checked in this change, which side steps the problem.
> > I'm not sure if this is really actually a bug, given that the item popped
> > from the savestack could not have been an array (its pointer isn't bitflipped)
> >
> > @@ -1035,8 +1045,10 @@
> > break;
> > case SAVEt_COMPPAD:
> > PL_comppad = (PAD*)SSPOPPTR;
> > - if (PL_comppad)
> > + if (PL_comppad && SvTYPE(PL_comppad) != SVTYPEMASK) {
> > + assert(SvTYPE(PL_comppad) == SVt_PVAV);
> > PL_curpad = AvARRAY(PL_comppad);
> > + }
> > else
> > PL_curpad = Null(SV**);
> > break;
>
> I've been busy today attaching skirting boards to the walls of my front
> room(*) so I haven't had a chance to look into it yet, but I will do in the
> next day or two.
It would be great if you are able to look, but there's no real hurry.
Beware of cvs up'ing parrot at the moment. It's just had a lot of changes
relating to ICU, and it's not linking/building on all platforms yet.
Nicholas Clark