Re: [PATCH] Refactoring to Sv*_set() macros - patch #2

[email protected] (Nicholas Clark) Mon, 11 Apr 2005 11:41:01 +0100
Newsgroups perl.perl5.porters,perl.ponie.dev
Message-ID <[email protected]>
On Mon, Apr 11, 2005 at 11:37:43AM +0100, Tim Bunce wrote:

> If assignments to SvIVX() are to be replaced with SVIV_set() then any
> extensions that assign to SvIVX() will also need to be changed to use
> SVIV_set().

I wasn't planning on forcing that.
Just warning that it would be less efficient.

> In order that the extensions can still build for old versions of perl
> the SVIV_set() macro needs to be added to PPPort.
> 
> Tim.
> 
> p.s. The DBI does scary things by taking the address of the integer
> result of SvIVX()! But I'll worry about that another day...

So does the core in two places, both related to the "debugger" code.
As far as I can tell it's actually a speedup for DProf.

I think that taking the address of SvIVX() can work (for all the caveats
that already has, such as don't ever allow anything to upgrade that scalar)

Nicholas Clark